* [PATCH v1] drm/bridge: of-display-mode-bridge: Fix missing static const for the bridge funcs
@ 2026-06-17 8:07 Damon Ding
2026-06-17 8:17 ` Laurent Pinchart
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Damon Ding @ 2026-06-17 8:07 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Luca Ceresoli,
dri-devel, linux-kernel, Damon Ding, kernel test robot
Add static qualifier for of_display_mode_bridge_funcs to resolve the
sparse warning:
drivers/gpu/drm/bridge/of-display-mode-bridge.c:54:25: sparse: sparse:
symbol 'of_display_mode_bridge_funcs' was not declared. Should it be
static?
Also mark the structure const as required by devm_drm_bridge_alloc()
parameter type constraints.
Fixes: ba2db93cf3d5 ("drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202606170744.FUStcWaB-lkp@intel.com/
Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
---
drivers/gpu/drm/bridge/of-display-mode-bridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/of-display-mode-bridge.c b/drivers/gpu/drm/bridge/of-display-mode-bridge.c
index cb15713f3a79..e66dae168fd0 100644
--- a/drivers/gpu/drm/bridge/of-display-mode-bridge.c
+++ b/drivers/gpu/drm/bridge/of-display-mode-bridge.c
@@ -51,7 +51,7 @@ static int of_display_mode_bridge_get_modes(struct drm_bridge *bridge,
return 0;
}
-struct drm_bridge_funcs of_display_mode_bridge_funcs = {
+static const struct drm_bridge_funcs of_display_mode_bridge_funcs = {
.attach = of_display_mode_bridge_attach,
.get_modes = of_display_mode_bridge_get_modes,
};
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] drm/bridge: of-display-mode-bridge: Fix missing static const for the bridge funcs
2026-06-17 8:07 [PATCH v1] drm/bridge: of-display-mode-bridge: Fix missing static const for the bridge funcs Damon Ding
@ 2026-06-17 8:17 ` Laurent Pinchart
2026-06-17 10:18 ` Luca Ceresoli
2026-06-26 16:44 ` Luca Ceresoli
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2026-06-17 8:17 UTC (permalink / raw)
To: Damon Ding
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Jonas Karlman, Jernej Skrabec, Luca Ceresoli, dri-devel,
linux-kernel, kernel test robot
On Wed, Jun 17, 2026 at 04:07:55PM +0800, Damon Ding wrote:
> Add static qualifier for of_display_mode_bridge_funcs to resolve the
> sparse warning:
>
> drivers/gpu/drm/bridge/of-display-mode-bridge.c:54:25: sparse: sparse:
> symbol 'of_display_mode_bridge_funcs' was not declared. Should it be
> static?
>
> Also mark the structure const as required by devm_drm_bridge_alloc()
> parameter type constraints.
>
> Fixes: ba2db93cf3d5 ("drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202606170744.FUStcWaB-lkp@intel.com/
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/of-display-mode-bridge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/of-display-mode-bridge.c b/drivers/gpu/drm/bridge/of-display-mode-bridge.c
> index cb15713f3a79..e66dae168fd0 100644
> --- a/drivers/gpu/drm/bridge/of-display-mode-bridge.c
> +++ b/drivers/gpu/drm/bridge/of-display-mode-bridge.c
> @@ -51,7 +51,7 @@ static int of_display_mode_bridge_get_modes(struct drm_bridge *bridge,
> return 0;
> }
>
> -struct drm_bridge_funcs of_display_mode_bridge_funcs = {
> +static const struct drm_bridge_funcs of_display_mode_bridge_funcs = {
> .attach = of_display_mode_bridge_attach,
> .get_modes = of_display_mode_bridge_get_modes,
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] drm/bridge: of-display-mode-bridge: Fix missing static const for the bridge funcs
2026-06-17 8:07 [PATCH v1] drm/bridge: of-display-mode-bridge: Fix missing static const for the bridge funcs Damon Ding
2026-06-17 8:17 ` Laurent Pinchart
@ 2026-06-17 10:18 ` Luca Ceresoli
2026-06-26 16:44 ` Luca Ceresoli
2 siblings, 0 replies; 4+ messages in thread
From: Luca Ceresoli @ 2026-06-17 10:18 UTC (permalink / raw)
To: Damon Ding
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Luca Ceresoli,
dri-devel, linux-kernel, kernel test robot
On Wed, 17 Jun 2026 16:07:55 +0800, Damon Ding <damon.ding@rock-chips.com> wrote:
> drm/bridge: of-display-mode-bridge: Fix missing static const for the bridge funcs
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] drm/bridge: of-display-mode-bridge: Fix missing static const for the bridge funcs
2026-06-17 8:07 [PATCH v1] drm/bridge: of-display-mode-bridge: Fix missing static const for the bridge funcs Damon Ding
2026-06-17 8:17 ` Laurent Pinchart
2026-06-17 10:18 ` Luca Ceresoli
@ 2026-06-26 16:44 ` Luca Ceresoli
2 siblings, 0 replies; 4+ messages in thread
From: Luca Ceresoli @ 2026-06-26 16:44 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Damon Ding
Cc: Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel,
linux-kernel, kernel test robot
On Wed, 17 Jun 2026 16:07:55 +0800, Damon Ding wrote:
> Add static qualifier for of_display_mode_bridge_funcs to resolve the
> sparse warning:
>
> drivers/gpu/drm/bridge/of-display-mode-bridge.c:54:25: sparse: sparse:
> symbol 'of_display_mode_bridge_funcs' was not declared. Should it be
> static?
>
> [...]
Applied, thanks!
[1/1] drm/bridge: of-display-mode-bridge: Fix missing static const for the bridge funcs
commit: 6648301c5bb2ef23f0fb15bcb01d21ff66f36799
Best regards,
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-06-26 16:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-17 8:07 [PATCH v1] drm/bridge: of-display-mode-bridge: Fix missing static const for the bridge funcs Damon Ding
2026-06-17 8:17 ` Laurent Pinchart
2026-06-17 10:18 ` Luca Ceresoli
2026-06-26 16:44 ` Luca Ceresoli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome