[PATCH] PCI: imx6: fix building against pwrctrl

[PATCH] PCI: imx6: fix building against pwrctrl

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

When endpoint mode is built-in, but pwrctrl support is in a loadable
module, the imx driver fails to build because the unused host
support still tries to link against pwrctrl:

ld.lld: error: undefined symbol: pci_pwrctrl_power_off_devices
>>> referenced by pci-imx6.c:1988 (drivers/pci/controller/dwc/pci-imx6.c:1988)
>>>               drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_shutdown) in archive vmlinux.a

Add one more select for this.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
----
There is already another fix pending that I sent earlier, see
https://lore.kernel.org/all/ajF_LyjOnINAHvA3@lizhi-Precision-Tower-5810/

If you prefer a combined patch, I can send an updated version,
or you can just fold the two into one commit when applying.
---
 drivers/pci/controller/dwc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 7d49027c6736..49a7a2c50ca1 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -128,6 +128,7 @@ config PCI_IMX6_EP
 	select PCIE_DW_EP
 	select PCI_HOST_COMMON
 	select PCI_IMX6
+	select PCI_PWRCTRL_GENERIC
 	help
 	  Enables support for the PCIe controller in the i.MX SoCs to
 	  work in endpoint mode. The PCI controller on i.MX is based
-- 
2.39.5

RE: [PATCH] PCI: imx6: fix building against pwrctrl

[Sherry Sun]

> Subject: [PATCH] PCI: imx6: fix building against pwrctrl
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> When endpoint mode is built-in, but pwrctrl support is in a loadable module,
> the imx driver fails to build because the unused host support still tries to link
> against pwrctrl:
>
> ld.lld: error: undefined symbol: pci_pwrctrl_power_off_devices
> >>> referenced by pci-imx6.c:1988 (drivers/pci/controller/dwc/pci-
> imx6.c:1988)
> >>>
> >>> drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_shutdown) in archive
> >>> vmlinux.a
>
> Add one more select for this.
>

Please add fixes tag:
Fixes: 85c1fcfa740d ("PCI: imx6: Integrate new pwrctrl API")
Then, Reviewed-by: Sherry Sun <sherry.sun@nxp.com>

Best Regards
Sherry

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ----
> There is already another fix pending that I sent earlier, see
> https://lore.ke/
> rnel.org%2Fall%2FajF_LyjOnINAHvA3%40lizhi-Precision-Tower-
> 5810%2F&data=05%7C02%7Csherry.sun%40nxp.com%7C3e0137032b804a37
> de3908decd471c75%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6
> 39173902484468360%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOn
> RydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ
> %3D%3D%7C0%7C%7C%7C&sdata=EoEuSedEedto7cGxbHL%2Fid4wcs6%2FTi
> BKI1sewlNdt%2FU%3D&reserved=0
>
> If you prefer a combined patch, I can send an updated version, or you can just
> fold the two into one commit when applying.
> ---
>  drivers/pci/controller/dwc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig
> b/drivers/pci/controller/dwc/Kconfig
> index 7d49027c6736..49a7a2c50ca1 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -128,6 +128,7 @@ config PCI_IMX6_EP
>       select PCIE_DW_EP
>       select PCI_HOST_COMMON
>       select PCI_IMX6
> +     select PCI_PWRCTRL_GENERIC
>       help
>         Enables support for the PCIe controller in the i.MX SoCs to
>         work in endpoint mode. The PCI controller on i.MX is based
> --
> 2.39.5
>

Re: [PATCH] PCI: imx6: fix building against pwrctrl

[Manivannan Sadhasivam]

On Thu, 18 Jun 2026 16:36:08 +0200, Arnd Bergmann wrote:
> When endpoint mode is built-in, but pwrctrl support is in a loadable
> module, the imx driver fails to build because the unused host
> support still tries to link against pwrctrl:
> 
> ld.lld: error: undefined symbol: pci_pwrctrl_power_off_devices
> >>> referenced by pci-imx6.c:1988 (drivers/pci/controller/dwc/pci-imx6.c:1988)
> >>>               drivers/pci/controller/dwc/pci-imx6.o:(imx_pcie_shutdown) in archive vmlinux.a
> 
> [...]

Applied, thanks!

[1/1] PCI: imx6: fix building against pwrctrl
      commit: 7f4d9901eb1fdd3d2e56b514dcc325b33185b8e1

Best regards,
-- 
மணிவண்ணன் சதாசிவம்