[QUESTION] staging: octeon: is the FIXME in cvm_oct_sgmii

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* [QUESTION] staging: octeon: is the FIXME in cvm_oct_sgmii_init stale?
@ 2026-06-17 21:07 Pablo D. Bergamasco
  2026-06-18 10:26 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Pablo D. Bergamasco @ 2026-06-17 21:07 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, danpablo

Hi Greg,

While looking at drivers/staging/octeon/ethernet-sgmii.c I noticed
a FIXME comment in cvm_oct_sgmii_init():

    cvm_oct_common_init(dev);
    /* FIXME: Need autoneg logic */
    return 0;

After tracing the code, I believe autoneg is already handled when
the interface is opened:

  cvm_oct_sgmii_open()
      -> cvm_oct_common_open()
          -> cvm_oct_phy_setup_device()
              -> phy_start()
                  -> phy_state_machine()
                      -> _phy_start_aneg()
                          -> genphy_config_aneg()

Is my analysis correct? If so, should I send a patch to remove
the stale FIXME comment?

Thanks,
Pablo D. Bergamasco

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [QUESTION] staging: octeon: is the FIXME in cvm_oct_sgmii_init stale?
  2026-06-17 21:07 [QUESTION] staging: octeon: is the FIXME in cvm_oct_sgmii_init stale? Pablo D. Bergamasco
@ 2026-06-18 10:26 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2026-06-18 10:26 UTC (permalink / raw)
  To: Pablo D. Bergamasco; +Cc: linux-staging, linux-kernel

On Wed, Jun 17, 2026 at 06:07:43PM -0300, Pablo D. Bergamasco wrote:
> Hi Greg,
> 
> While looking at drivers/staging/octeon/ethernet-sgmii.c I noticed
> a FIXME comment in cvm_oct_sgmii_init():
> 
>     cvm_oct_common_init(dev);
>     /* FIXME: Need autoneg logic */
>     return 0;
> 
> After tracing the code, I believe autoneg is already handled when
> the interface is opened:
> 
>   cvm_oct_sgmii_open()
>       -> cvm_oct_common_open()
>           -> cvm_oct_phy_setup_device()
>               -> phy_start()
>                   -> phy_state_machine()
>                       -> _phy_start_aneg()
>                           -> genphy_config_aneg()
> 
> Is my analysis correct? If so, should I send a patch to remove
> the stale FIXME comment?

I have no idea, sorry, test it out on the hardware and see!

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-18 10:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-17 21:07 [QUESTION] staging: octeon: is the FIXME in cvm_oct_sgmii_init stale? Pablo D. Bergamasco
2026-06-18 10:26 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®