mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] of: fdt: Replace __ASSEMBLY__ with __ASSEMBLER__ in of_fdt.h header file
@ 2026-06-19 16:02 Thomas Huth
  2026-08-13  7:40 ` Thomas Huth
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2026-06-19 16:02 UTC (permalink / raw)
  To: Rob Herring, Saravana Kannan, linux-kernel

From: Thomas Huth <thuth@redhat.com>

While the GCC and Clang compilers already define __ASSEMBLER__
automatically when compiling assembly code, __ASSEMBLY__ is a
macro that only gets defined by the Makefiles in the kernel.
This can be very confusing when switching between userspace
and kernelspace coding, or when dealing with uapi headers that
rather should use __ASSEMBLER__ instead. So let's standardize now
on the __ASSEMBLER__ macro that is provided by the compilers.

This is a completely mechanical patch (done with a simple "sed -i"
statement).

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 Note: This patch has been split from an earlier bigger patch of
 mine to ease reviewing.

 include/linux/of_fdt.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
index 51dadbaa3d63a..72b452e388eeb 100644
--- a/include/linux/of_fdt.h
+++ b/include/linux/of_fdt.h
@@ -16,7 +16,7 @@
 /* Definitions used by the flattened device tree */
 #define OF_DT_HEADER		0xd00dfeed	/* marker */
 
-#ifndef __ASSEMBLY__
+#ifndef __ASSEMBLER__
 
 #if defined(CONFIG_OF_FLATTREE)
 
@@ -103,5 +103,5 @@ static inline void unflatten_device_tree(void) {}
 static inline void unflatten_and_copy_device_tree(void) {}
 #endif /* CONFIG_OF_EARLY_FLATTREE */
 
-#endif /* __ASSEMBLY__ */
+#endif /* __ASSEMBLER__ */
 #endif /* _LINUX_OF_FDT_H */
-- 
2.54.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] of: fdt: Replace __ASSEMBLY__ with __ASSEMBLER__ in of_fdt.h header file
  2026-06-19 16:02 [PATCH] of: fdt: Replace __ASSEMBLY__ with __ASSEMBLER__ in of_fdt.h header file Thomas Huth
@ 2026-08-13  7:40 ` Thomas Huth
  2026-09-22  6:23   ` Thomas Huth
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2026-08-13  7:40 UTC (permalink / raw)
  To: Rob Herring, Saravana Kannan, linux-kernel
  Cc: Krzysztof Kozlowski, Conor Dooley, devicetree

On 19/06/2026 18.02, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> While the GCC and Clang compilers already define __ASSEMBLER__
> automatically when compiling assembly code, __ASSEMBLY__ is a
> macro that only gets defined by the Makefiles in the kernel.
> This can be very confusing when switching between userspace
> and kernelspace coding, or when dealing with uapi headers that
> rather should use __ASSEMBLER__ instead. So let's standardize now
> on the __ASSEMBLER__ macro that is provided by the compilers.
> 
> This is a completely mechanical patch (done with a simple "sed -i"
> statement).
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   Note: This patch has been split from an earlier bigger patch of
>   mine to ease reviewing.
> 
>   include/linux/of_fdt.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
> index 51dadbaa3d63a..72b452e388eeb 100644
> --- a/include/linux/of_fdt.h
> +++ b/include/linux/of_fdt.h
> @@ -16,7 +16,7 @@
>  /* Definitions used by the flattened device tree */
>  #define OF_DT_HEADER		0xd00dfeed	/* marker */
>   
> -#ifndef __ASSEMBLY__
> +#ifndef __ASSEMBLER__
>  
>  #if defined(CONFIG_OF_FLATTREE)
>  
> @@ -103,5 +103,5 @@ static inline void unflatten_device_tree(void) {}
>  static inline void unflatten_and_copy_device_tree(void) {}
>  #endif /* CONFIG_OF_EARLY_FLATTREE */
>  
> -#endif /* __ASSEMBLY__ */
> +#endif /* __ASSEMBLER__ */
>  #endif /* _LINUX_OF_FDT_H */

Friendly ping!

Could anybody please pick this up? Thanks!

  Thomas


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] of: fdt: Replace __ASSEMBLY__ with __ASSEMBLER__ in of_fdt.h header file
  2026-08-13  7:40 ` Thomas Huth
@ 2026-09-22  6:23   ` Thomas Huth
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2026-09-22  6:23 UTC (permalink / raw)
  To: Rob Herring, Saravana Kannan, linux-kernel
  Cc: Krzysztof Kozlowski, Conor Dooley, devicetree

On 13/08/2026 09.40, Thomas Huth wrote:
> On 19/06/2026 18.02, Thomas Huth wrote:
>> From: Thomas Huth <thuth@redhat.com>
>>
>> While the GCC and Clang compilers already define __ASSEMBLER__
>> automatically when compiling assembly code, __ASSEMBLY__ is a
>> macro that only gets defined by the Makefiles in the kernel.
>> This can be very confusing when switching between userspace
>> and kernelspace coding, or when dealing with uapi headers that
>> rather should use __ASSEMBLER__ instead. So let's standardize now
>> on the __ASSEMBLER__ macro that is provided by the compilers.
>>
>> This is a completely mechanical patch (done with a simple "sed -i"
>> statement).
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   Note: This patch has been split from an earlier bigger patch of
>>   mine to ease reviewing.
>>
>>   include/linux/of_fdt.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
>> index 51dadbaa3d63a..72b452e388eeb 100644
>> --- a/include/linux/of_fdt.h
>> +++ b/include/linux/of_fdt.h
>> @@ -16,7 +16,7 @@
>>  /* Definitions used by the flattened device tree */
>>  #define OF_DT_HEADER        0xd00dfeed    /* marker */
>> -#ifndef __ASSEMBLY__
>> +#ifndef __ASSEMBLER__
>>
>>  #if defined(CONFIG_OF_FLATTREE)
>>
>> @@ -103,5 +103,5 @@ static inline void unflatten_device_tree(void) {}
>>  static inline void unflatten_and_copy_device_tree(void) {}
>>  #endif /* CONFIG_OF_EARLY_FLATTREE */
>>
>> -#endif /* __ASSEMBLY__ */
>> +#endif /* __ASSEMBLER__ */
>>  #endif /* _LINUX_OF_FDT_H */
> 
> Friendly ping!
Ping again!

Rob, Saravana, it's not a big patch, could you please pick it up? (or tell 
me if you don't like it, then I'll stop annoying you ;-))

  Thanks,
   Thomas


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-22  6:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-19 16:02 [PATCH] of: fdt: Replace __ASSEMBLY__ with __ASSEMBLER__ in of_fdt.h header file Thomas Huth
2026-08-13  7:40 ` Thomas Huth
2026-09-22  6:23   ` Thomas Huth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®