* Re: [PATCH] x86/boot/compressed/head_64.S: Cleanup SEV-related comments
2026-06-20 4:37 [PATCH] x86/boot/compressed/head_64.S: Cleanup SEV-related comments Borislav Petkov
@ 2026-07-08 18:50 ` Tom Lendacky
2026-07-10 0:25 ` [tip: x86/cleanups] " tip-bot2 for Borislav Petkov (AMD)
2026-07-10 9:24 ` [tip: x86/cleanups] x86/boot/compressed/head_64.S: Clean up " tip-bot2 for Borislav Petkov (AMD)
2 siblings, 0 replies; 4+ messages in thread
From: Tom Lendacky @ 2026-07-08 18:50 UTC (permalink / raw)
To: Borislav Petkov; +Cc: X86 ML, LKML, Borislav Petkov (AMD)
On 6/19/26 23:37, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
>
> Move the comment about setting the encryption mask above the line which
> does that and, especially, inside the ifdeffery, where it belongs.
>
> Move comments ontop of the code lines they refer to and not on the
> side, which impairs readability.
>
> No functional changes.
>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> arch/x86/boot/compressed/head_64.S | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/arch/x86/boot/compressed/head_64.S b/arch/x86/boot/compressed/head_64.S
> index d9dab940ff62..1aca51390f73 100644
> --- a/arch/x86/boot/compressed/head_64.S
> +++ b/arch/x86/boot/compressed/head_64.S
> @@ -172,19 +172,23 @@ SYM_FUNC_START(startup_32)
> /*
> * Build early 4G boot pagetable
> */
> - /*
> - * If SEV is active then set the encryption mask in the page tables.
> - * This will ensure that when the kernel is copied and decompressed
> - * it will be done so encrypted.
> - */
> xorl %edx, %edx
> #ifdef CONFIG_AMD_MEM_ENCRYPT
> call get_sev_encryption_bit
> xorl %edx, %edx
> testl %eax, %eax
> jz 1f
> - subl $32, %eax /* Encryption bit is always above bit 31 */
> - bts %eax, %edx /* Set encryption mask for page tables */
> +
> + /* Encryption bit is always above bit 31 */
> + subl $32, %eax
> +
> + /*
> + * If SEV is active then set the encryption mask in the page tables.
> + * This will ensure that when the kernel is copied and decompressed it
> + * will be done so encrypted.
> + */
> + bts %eax, %edx
> +
> /*
> * Set MSR_AMD64_SEV_ENABLED_BIT in sev_status so that
> * startup32_check_sev_cbit() will do a check. sev_enable() will
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip: x86/cleanups] x86/boot/compressed/head_64.S: Cleanup SEV-related comments
2026-06-20 4:37 [PATCH] x86/boot/compressed/head_64.S: Cleanup SEV-related comments Borislav Petkov
2026-07-08 18:50 ` Tom Lendacky
@ 2026-07-10 0:25 ` tip-bot2 for Borislav Petkov (AMD)
2026-07-10 9:24 ` [tip: x86/cleanups] x86/boot/compressed/head_64.S: Clean up " tip-bot2 for Borislav Petkov (AMD)
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for Borislav Petkov (AMD) @ 2026-07-10 0:25 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Borislav Petkov (AMD), Tom Lendacky, x86, linux-kernel
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: cb6417b360a7ad215cde42aa2cf56a2076cac560
Gitweb: https://git.kernel.org/tip/cb6417b360a7ad215cde42aa2cf56a2076cac560
Author: Borislav Petkov (AMD) <bp@alien8.de>
AuthorDate: Fri, 19 Jun 2026 21:37:57 -07:00
Committer: Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Thu, 09 Jul 2026 16:16:32 -07:00
x86/boot/compressed/head_64.S: Cleanup SEV-related comments
Move the comment about setting the encryption mask above the line which
does that and, especially, inside the ifdeffery, where it belongs.
Move comments ontop of the code lines they refer to and not on the
side, which impairs readability.
No functional changes.
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
Link: https://patch.msgid.link/20260620043757.347076-1-bp@kernel.org
---
arch/x86/boot/compressed/head_64.S | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/arch/x86/boot/compressed/head_64.S b/arch/x86/boot/compressed/head_64.S
index d9dab94..1aca513 100644
--- a/arch/x86/boot/compressed/head_64.S
+++ b/arch/x86/boot/compressed/head_64.S
@@ -172,19 +172,23 @@ SYM_FUNC_START(startup_32)
/*
* Build early 4G boot pagetable
*/
- /*
- * If SEV is active then set the encryption mask in the page tables.
- * This will ensure that when the kernel is copied and decompressed
- * it will be done so encrypted.
- */
xorl %edx, %edx
#ifdef CONFIG_AMD_MEM_ENCRYPT
call get_sev_encryption_bit
xorl %edx, %edx
testl %eax, %eax
jz 1f
- subl $32, %eax /* Encryption bit is always above bit 31 */
- bts %eax, %edx /* Set encryption mask for page tables */
+
+ /* Encryption bit is always above bit 31 */
+ subl $32, %eax
+
+ /*
+ * If SEV is active then set the encryption mask in the page tables.
+ * This will ensure that when the kernel is copied and decompressed it
+ * will be done so encrypted.
+ */
+ bts %eax, %edx
+
/*
* Set MSR_AMD64_SEV_ENABLED_BIT in sev_status so that
* startup32_check_sev_cbit() will do a check. sev_enable() will
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip: x86/cleanups] x86/boot/compressed/head_64.S: Clean up SEV-related comments
2026-06-20 4:37 [PATCH] x86/boot/compressed/head_64.S: Cleanup SEV-related comments Borislav Petkov
2026-07-08 18:50 ` Tom Lendacky
2026-07-10 0:25 ` [tip: x86/cleanups] " tip-bot2 for Borislav Petkov (AMD)
@ 2026-07-10 9:24 ` tip-bot2 for Borislav Petkov (AMD)
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for Borislav Petkov (AMD) @ 2026-07-10 9:24 UTC (permalink / raw)
To: linux-tip-commits
Cc: Borislav Petkov (AMD), Ingo Molnar, Tom Lendacky, x86, linux-kernel
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 7bdcb5b3a9c5ea63aaea75adfc1ffd30dee969f0
Gitweb: https://git.kernel.org/tip/7bdcb5b3a9c5ea63aaea75adfc1ffd30dee969f0
Author: Borislav Petkov (AMD) <bp@alien8.de>
AuthorDate: Fri, 19 Jun 2026 21:37:57 -07:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Fri, 10 Jul 2026 11:21:51 +02:00
x86/boot/compressed/head_64.S: Clean up SEV-related comments
Move the comment about setting the encryption mask above the line which
does that and, especially, inside the ifdeffery, where it belongs.
Move comments on top of the code lines they refer to and not on the
side, which impairs readability.
No functional changes.
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
Link: https://patch.msgid.link/20260620043757.347076-1-bp@kernel.org
---
arch/x86/boot/compressed/head_64.S | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/arch/x86/boot/compressed/head_64.S b/arch/x86/boot/compressed/head_64.S
index d9dab94..1aca513 100644
--- a/arch/x86/boot/compressed/head_64.S
+++ b/arch/x86/boot/compressed/head_64.S
@@ -172,19 +172,23 @@ SYM_FUNC_START(startup_32)
/*
* Build early 4G boot pagetable
*/
- /*
- * If SEV is active then set the encryption mask in the page tables.
- * This will ensure that when the kernel is copied and decompressed
- * it will be done so encrypted.
- */
xorl %edx, %edx
#ifdef CONFIG_AMD_MEM_ENCRYPT
call get_sev_encryption_bit
xorl %edx, %edx
testl %eax, %eax
jz 1f
- subl $32, %eax /* Encryption bit is always above bit 31 */
- bts %eax, %edx /* Set encryption mask for page tables */
+
+ /* Encryption bit is always above bit 31 */
+ subl $32, %eax
+
+ /*
+ * If SEV is active then set the encryption mask in the page tables.
+ * This will ensure that when the kernel is copied and decompressed it
+ * will be done so encrypted.
+ */
+ bts %eax, %edx
+
/*
* Set MSR_AMD64_SEV_ENABLED_BIT in sev_status so that
* startup32_check_sev_cbit() will do a check. sev_enable() will
^ permalink raw reply [flat|nested] 4+ messages in thread