* [PATCH] mmc: dw_mmc: add declaration of dw_mci_pmops
@ 2026-06-23 10:23 Ben Dooks
2026-07-06 14:30 ` Ulf Hansson
0 siblings, 1 reply; 4+ messages in thread
From: Ben Dooks @ 2026-06-23 10:23 UTC (permalink / raw)
To: Jaehoon Chung, Shawn Lin, Ulf Hansson, linux-mmc, linux-kernel; +Cc: Ben Dooks
The dw_mci_pmops is exported out of dw_mmc.c so add a declaration of
it in dw_mmc.h to fix the following sparse warning:
drivers/mmc/host/dw_mmc.c:3512:25: warning: symbol 'dw_mci_pmops' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
drivers/mmc/host/dw_mmc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
index 9ffcd3946cff..38610c89d54a 100644
--- a/drivers/mmc/host/dw_mmc.h
+++ b/drivers/mmc/host/dw_mmc.h
@@ -19,6 +19,8 @@
#include <linux/interrupt.h>
#include <linux/workqueue.h>
+extern const struct dev_pm_ops dw_mci_pmops;
+
enum dw_mci_state {
STATE_IDLE = 0,
STATE_SENDING_CMD,
--
2.37.2.352.g3c44437643
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: dw_mmc: add declaration of dw_mci_pmops
2026-06-23 10:23 [PATCH] mmc: dw_mmc: add declaration of dw_mci_pmops Ben Dooks
@ 2026-07-06 14:30 ` Ulf Hansson
2026-07-06 18:25 ` Ben Dooks
0 siblings, 1 reply; 4+ messages in thread
From: Ulf Hansson @ 2026-07-06 14:30 UTC (permalink / raw)
To: Ben Dooks; +Cc: Jaehoon Chung, Shawn Lin, Ulf Hansson, linux-mmc, linux-kernel
On Tue, Jun 23, 2026 at 12:24 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> The dw_mci_pmops is exported out of dw_mmc.c so add a declaration of
> it in dw_mmc.h to fix the following sparse warning:
>
> drivers/mmc/host/dw_mmc.c:3512:25: warning: symbol 'dw_mci_pmops' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> drivers/mmc/host/dw_mmc.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
> index 9ffcd3946cff..38610c89d54a 100644
> --- a/drivers/mmc/host/dw_mmc.h
> +++ b/drivers/mmc/host/dw_mmc.h
> @@ -19,6 +19,8 @@
> #include <linux/interrupt.h>
> #include <linux/workqueue.h>
>
> +extern const struct dev_pm_ops dw_mci_pmops;
> +
It's already extern declared in drivers/mmc/host/dw_mmc-pltfm.h.
Perhaps drop that then?
> enum dw_mci_state {
> STATE_IDLE = 0,
> STATE_SENDING_CMD,
> --
> 2.37.2.352.g3c44437643
>
Kind regards
Uffe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: dw_mmc: add declaration of dw_mci_pmops
2026-07-06 14:30 ` Ulf Hansson
@ 2026-07-06 18:25 ` Ben Dooks
2026-07-07 10:21 ` Ulf Hansson
0 siblings, 1 reply; 4+ messages in thread
From: Ben Dooks @ 2026-07-06 18:25 UTC (permalink / raw)
To: Ulf Hansson
Cc: Jaehoon Chung, Shawn Lin, Ulf Hansson, linux-mmc, linux-kernel
On 06/07/2026 15:30, Ulf Hansson wrote:
> On Tue, Jun 23, 2026 at 12:24 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>>
>> The dw_mci_pmops is exported out of dw_mmc.c so add a declaration of
>> it in dw_mmc.h to fix the following sparse warning:
>>
>> drivers/mmc/host/dw_mmc.c:3512:25: warning: symbol 'dw_mci_pmops' was not declared. Should it be static?
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> drivers/mmc/host/dw_mmc.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
>> index 9ffcd3946cff..38610c89d54a 100644
>> --- a/drivers/mmc/host/dw_mmc.h
>> +++ b/drivers/mmc/host/dw_mmc.h
>> @@ -19,6 +19,8 @@
>> #include <linux/interrupt.h>
>> #include <linux/workqueue.h>
>>
>> +extern const struct dev_pm_ops dw_mci_pmops;
>> +
>
> It's already extern declared in drivers/mmc/host/dw_mmc-pltfm.h.
> Perhaps drop that then?
so just move it into dw_mmc.h?
>
>> enum dw_mci_state {
>> STATE_IDLE = 0,
>> STATE_SENDING_CMD,
>> --
>> 2.37.2.352.g3c44437643
>>
>
> Kind regards
> Uffe
>
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: dw_mmc: add declaration of dw_mci_pmops
2026-07-06 18:25 ` Ben Dooks
@ 2026-07-07 10:21 ` Ulf Hansson
0 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2026-07-07 10:21 UTC (permalink / raw)
To: Ben Dooks; +Cc: Jaehoon Chung, Shawn Lin, Ulf Hansson, linux-mmc, linux-kernel
On Mon, Jul 6, 2026 at 8:25 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> On 06/07/2026 15:30, Ulf Hansson wrote:
> > On Tue, Jun 23, 2026 at 12:24 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> >>
> >> The dw_mci_pmops is exported out of dw_mmc.c so add a declaration of
> >> it in dw_mmc.h to fix the following sparse warning:
> >>
> >> drivers/mmc/host/dw_mmc.c:3512:25: warning: symbol 'dw_mci_pmops' was not declared. Should it be static?
> >>
> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> >> ---
> >> drivers/mmc/host/dw_mmc.h | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
> >> index 9ffcd3946cff..38610c89d54a 100644
> >> --- a/drivers/mmc/host/dw_mmc.h
> >> +++ b/drivers/mmc/host/dw_mmc.h
> >> @@ -19,6 +19,8 @@
> >> #include <linux/interrupt.h>
> >> #include <linux/workqueue.h>
> >>
> >> +extern const struct dev_pm_ops dw_mci_pmops;
> >> +
> >
> > It's already extern declared in drivers/mmc/host/dw_mmc-pltfm.h.
> > Perhaps drop that then?
>
> so just move it into dw_mmc.h?
Yes, that seems reasonable to me.
[...]
Kind regards
Uffe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-07-07 10:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-23 10:23 [PATCH] mmc: dw_mmc: add declaration of dw_mci_pmops Ben Dooks
2026-07-06 14:30 ` Ulf Hansson
2026-07-06 18:25 ` Ben Dooks
2026-07-07 10:21 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox