mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] blkcg: update iocost_coef_gen.py to use io_uring
@ 2026-06-24 14:50 Jeff Layton
  2026-06-24 16:48 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Layton @ 2026-06-24 14:50 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-kernel, Tejun Heo, linux-block, Jeff Layton

Recently I found myself having to benchmark some rather fast disks for
iocost, but the old iocost_coef_gen.py script couldn't generate enough
throughput to saturate it. Make it use io_uring instead.

Cc: Tejun Heo <tj@kernel.org>
Cc: linux-block@vger.kernel.org
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 tools/cgroup/iocost_coef_gen.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/cgroup/iocost_coef_gen.py b/tools/cgroup/iocost_coef_gen.py
index df17a2ae80e5..41f93f4536cc 100644
--- a/tools/cgroup/iocost_coef_gen.py
+++ b/tools/cgroup/iocost_coef_gen.py
@@ -91,7 +91,7 @@ def run_fio(testfile, duration, iotype, iodepth, blocksize, jobs):
 
     eta = 'never' if args.quiet else 'always'
     outfile = tempfile.NamedTemporaryFile()
-    cmd = (f'fio --direct=1 --ioengine=libaio --name=coef '
+    cmd = (f'fio --direct=1 --ioengine=io_uring --name=coef '
            f'--filename={testfile} --runtime={round(duration)} '
            f'--readwrite={iotype} --iodepth={iodepth} --blocksize={blocksize} '
            f'--eta={eta} --output-format json --output={outfile.name} '

---
base-commit: 840ef6c78e6a2f694b578ecb9063241c992aaa9e
change-id: 20260624-iocost-a196820cc049

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] blkcg: update iocost_coef_gen.py to use io_uring
  2026-06-24 14:50 [PATCH] blkcg: update iocost_coef_gen.py to use io_uring Jeff Layton
@ 2026-06-24 16:48 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2026-06-24 16:48 UTC (permalink / raw)
  To: Jeff Layton; +Cc: Jens Axboe, linux-kernel, linux-block

On Wed, Jun 24, 2026 at 10:50:34AM -0400, Jeff Layton wrote:
> Recently I found myself having to benchmark some rather fast disks for
> iocost, but the old iocost_coef_gen.py script couldn't generate enough
> throughput to saturate it. Make it use io_uring instead.
> 
> Cc: Tejun Heo <tj@kernel.org>
> Cc: linux-block@vger.kernel.org
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-24 16:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-24 14:50 [PATCH] blkcg: update iocost_coef_gen.py to use io_uring Jeff Layton
2026-06-24 16:48 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®