* [PATCH v8] Bluetooth: btbcm: Add Synaptics 4384 chip support
@ 2026-06-24 8:19 kaihsin Chung
2026-06-24 12:30 ` Paul Menzel
2026-07-01 8:01 ` [PATCH v9] " Kaihsin Chung
0 siblings, 2 replies; 3+ messages in thread
From: kaihsin Chung @ 2026-06-24 8:19 UTC (permalink / raw)
To: linux-bluetooth; +Cc: marcel, luiz.dentz, linux-kernel, kaihsin Chung
Add support for the Synaptics 4384 Bluetooth controller
by adding the corresponding chip IDs.
Signed-off-by: Kaihsin Chung <kaihsin.chung@synaptics.com>
---
drivers/bluetooth/btbcm.c | 6 +++++-
drivers/bluetooth/hci_bcm.c | 1 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index 463d59890bef..1caa1c9468d8 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -31,6 +31,7 @@
#define BDADDR_BCM4334B0 (&(bdaddr_t) {{0x00, 0x00, 0x00, 0xb0, 0x34, 0x43}})
#define BDADDR_BCM4345C5 (&(bdaddr_t) {{0xac, 0x1f, 0x00, 0xc5, 0x45, 0x43}})
#define BDADDR_BCM43341B (&(bdaddr_t) {{0xac, 0x1f, 0x00, 0x1b, 0x34, 0x43}})
+#define BDADDR_BCM4384B0 (&(bdaddr_t) {{0x93, 0x76, 0x00, 0xb0, 0x84, 0x43}})
#define BCM_FW_NAME_LEN 64
#define BCM_FW_NAME_COUNT_MAX 4
@@ -130,7 +131,8 @@ int btbcm_check_bdaddr(struct hci_dev *hdev)
!bacmp(&bda->bdaddr, BDADDR_BCM4345C5) ||
!bacmp(&bda->bdaddr, BDADDR_BCM43430A0) ||
!bacmp(&bda->bdaddr, BDADDR_BCM43430A1) ||
- !bacmp(&bda->bdaddr, BDADDR_BCM43341B)) {
+ !bacmp(&bda->bdaddr, BDADDR_BCM43341B) ||
+ !bacmp(&bda->bdaddr, BDADDR_BCM4384B0)) {
/* Try falling back to BDADDR EFI variable */
if (btbcm_set_bdaddr_from_efi(hdev) != 0) {
bt_dev_info(hdev, "BCM: Using default device address (%pMR)",
@@ -514,6 +516,8 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = {
{ 0x4106, "BCM4335A0" }, /* 002.001.006 */
{ 0x410c, "BCM43430B0" }, /* 002.001.012 */
{ 0x2119, "BCM4373A0" }, /* 001.001.025 */
+ { 0x2128, "BCM4384A0" },/* 001.001.040 */
+ { 0x4119, "BCM4384B0"},/* 002.001.025 */
{ }
};
diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 1a4fc3882fd2..d306da6a46ff 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -1594,6 +1594,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
{ .compatible = "brcm,bcm4335a0" },
{ .compatible = "cypress,cyw4373a0-bt", .data = &cyw4373a0_device_data },
{ .compatible = "infineon,cyw55572-bt", .data = &cyw55572_device_data },
+ { .compatible = "brcm,bcm4384-bt" },
{ },
};
MODULE_DEVICE_TABLE(of, bcm_bluetooth_of_match);
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v8] Bluetooth: btbcm: Add Synaptics 4384 chip support
2026-06-24 8:19 [PATCH v8] Bluetooth: btbcm: Add Synaptics 4384 chip support kaihsin Chung
@ 2026-06-24 12:30 ` Paul Menzel
2026-07-01 8:01 ` [PATCH v9] " Kaihsin Chung
1 sibling, 0 replies; 3+ messages in thread
From: Paul Menzel @ 2026-06-24 12:30 UTC (permalink / raw)
To: Kaihsin Chung
Cc: marcel, luiz.dentz, linux-bluetooth, linux-kernel, Kaihsin Chung
Dear Kaihsin,
Thank you for your patch. Just a note, that your given name should also
start with a capital letter.
Am 24.06.26 um 10:19 schrieb kaihsin Chung:
> Add support for the Synaptics 4384 Bluetooth controller
> by adding the corresponding chip IDs.
Please mention the source for the ids, like a datasheet name.
Also, please document in the commit message, how you tested this.
> Signed-off-by: Kaihsin Chung <kaihsin.chung@synaptics.com>
> ---
> drivers/bluetooth/btbcm.c | 6 +++++-
> drivers/bluetooth/hci_bcm.c | 1 +
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index 463d59890bef..1caa1c9468d8 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
> @@ -31,6 +31,7 @@
> #define BDADDR_BCM4334B0 (&(bdaddr_t) {{0x00, 0x00, 0x00, 0xb0, 0x34, 0x43}})
> #define BDADDR_BCM4345C5 (&(bdaddr_t) {{0xac, 0x1f, 0x00, 0xc5, 0x45, 0x43}})
> #define BDADDR_BCM43341B (&(bdaddr_t) {{0xac, 0x1f, 0x00, 0x1b, 0x34, 0x43}})
> +#define BDADDR_BCM4384B0 (&(bdaddr_t) {{0x93, 0x76, 0x00, 0xb0, 0x84, 0x43}})
>
> #define BCM_FW_NAME_LEN 64
> #define BCM_FW_NAME_COUNT_MAX 4
> @@ -130,7 +131,8 @@ int btbcm_check_bdaddr(struct hci_dev *hdev)
> !bacmp(&bda->bdaddr, BDADDR_BCM4345C5) ||
> !bacmp(&bda->bdaddr, BDADDR_BCM43430A0) ||
> !bacmp(&bda->bdaddr, BDADDR_BCM43430A1) ||
> - !bacmp(&bda->bdaddr, BDADDR_BCM43341B)) {
> + !bacmp(&bda->bdaddr, BDADDR_BCM43341B) ||
> + !bacmp(&bda->bdaddr, BDADDR_BCM4384B0)) {
> /* Try falling back to BDADDR EFI variable */
> if (btbcm_set_bdaddr_from_efi(hdev) != 0) {
> bt_dev_info(hdev, "BCM: Using default device address (%pMR)",
> @@ -514,6 +516,8 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = {
> { 0x4106, "BCM4335A0" }, /* 002.001.006 */
> { 0x410c, "BCM43430B0" }, /* 002.001.012 */
> { 0x2119, "BCM4373A0" }, /* 001.001.025 */
> + { 0x2128, "BCM4384A0" },/* 001.001.040 */
> + { 0x4119, "BCM4384B0"},/* 002.001.025 */
Please align everything with the existing lines (} and /*).
> { }
> };
>
> diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> index 1a4fc3882fd2..d306da6a46ff 100644
> --- a/drivers/bluetooth/hci_bcm.c
> +++ b/drivers/bluetooth/hci_bcm.c
> @@ -1594,6 +1594,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
> { .compatible = "brcm,bcm4335a0" },
> { .compatible = "cypress,cyw4373a0-bt", .data = &cyw4373a0_device_data },
> { .compatible = "infineon,cyw55572-bt", .data = &cyw55572_device_data },
> + { .compatible = "brcm,bcm4384-bt" },
Put it two lines above below the existing brcm line?
> { },
> };
> MODULE_DEVICE_TABLE(of, bcm_bluetooth_of_match);
Kind regards,
Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v9] Bluetooth: btbcm: Add Synaptics 4384 chip support
2026-06-24 8:19 [PATCH v8] Bluetooth: btbcm: Add Synaptics 4384 chip support kaihsin Chung
2026-06-24 12:30 ` Paul Menzel
@ 2026-07-01 8:01 ` Kaihsin Chung
1 sibling, 0 replies; 3+ messages in thread
From: Kaihsin Chung @ 2026-07-01 8:01 UTC (permalink / raw)
To: linux-bluetooth; +Cc: marcel, luiz.dentz, linux-kernel, Kaihsin Chung
Add support for the Synaptics 4384 Bluetooth controller
by adding the corresponding chip IDs.
Verify the change on the VIM3 platform
Changes in v9:
- Align bcm_uart_subver_table formatting.
- Group the Broadcom DT compatible entries together.
- Capitalize the author's given name.
Signed-off-by: Kaihsin Chung <kaihsin.chung@synaptics.com>
---
drivers/bluetooth/btbcm.c | 6 +++++-
drivers/bluetooth/hci_bcm.c | 1 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index 463d59890bef..63c4c788d9c4 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -31,6 +31,7 @@
#define BDADDR_BCM4334B0 (&(bdaddr_t) {{0x00, 0x00, 0x00, 0xb0, 0x34, 0x43}})
#define BDADDR_BCM4345C5 (&(bdaddr_t) {{0xac, 0x1f, 0x00, 0xc5, 0x45, 0x43}})
#define BDADDR_BCM43341B (&(bdaddr_t) {{0xac, 0x1f, 0x00, 0x1b, 0x34, 0x43}})
+#define BDADDR_BCM4384B0 (&(bdaddr_t) {{0x93, 0x76, 0x00, 0xb0, 0x84, 0x43}})
#define BCM_FW_NAME_LEN 64
#define BCM_FW_NAME_COUNT_MAX 4
@@ -130,7 +131,8 @@ int btbcm_check_bdaddr(struct hci_dev *hdev)
!bacmp(&bda->bdaddr, BDADDR_BCM4345C5) ||
!bacmp(&bda->bdaddr, BDADDR_BCM43430A0) ||
!bacmp(&bda->bdaddr, BDADDR_BCM43430A1) ||
- !bacmp(&bda->bdaddr, BDADDR_BCM43341B)) {
+ !bacmp(&bda->bdaddr, BDADDR_BCM43341B) ||
+ !bacmp(&bda->bdaddr, BDADDR_BCM4384B0)) {
/* Try falling back to BDADDR EFI variable */
if (btbcm_set_bdaddr_from_efi(hdev) != 0) {
bt_dev_info(hdev, "BCM: Using default device address (%pMR)",
@@ -514,6 +516,8 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = {
{ 0x4106, "BCM4335A0" }, /* 002.001.006 */
{ 0x410c, "BCM43430B0" }, /* 002.001.012 */
{ 0x2119, "BCM4373A0" }, /* 001.001.025 */
+ { 0x2128, "BCM4384A0" }, /* 001.001.040 */
+ { 0x4119, "BCM4384B0" }, /* 002.001.025 */
{ }
};
diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 1a4fc3882fd2..6773079d4af4 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -1592,6 +1592,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
{ .compatible = "brcm,bcm4349-bt", .data = &bcm43438_device_data },
{ .compatible = "brcm,bcm43540-bt", .data = &bcm4354_device_data },
{ .compatible = "brcm,bcm4335a0" },
+ { .compatible = "brcm,bcm4384-bt" },
{ .compatible = "cypress,cyw4373a0-bt", .data = &cyw4373a0_device_data },
{ .compatible = "infineon,cyw55572-bt", .data = &cyw55572_device_data },
{ },
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-01 8:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-24 8:19 [PATCH v8] Bluetooth: btbcm: Add Synaptics 4384 chip support kaihsin Chung
2026-06-24 12:30 ` Paul Menzel
2026-07-01 8:01 ` [PATCH v9] " Kaihsin Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox