From: Anas Khan <anxkhn28@gmail.com>
To: Lyude Paul <lyude@redhat.com>, Danilo Krummrich <dakr@kernel.org>
Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Anas Khan <anxkhn28@gmail.com>
Subject: [PATCH] drm/nouveau/therm: remove unreachable fan update branch
Date: Fri, 3 Jul 2026 01:15:40 +0530 [thread overview]
Message-ID: <20260702194540.65127-1-anxkhn28@gmail.com> (raw)
The fan re-scheduling logic sits inside an "if (target != duty)" block,
so by the time the inner if/else-if chain runs, duty can never equal
target. The "else if (duty == target)" branch is therefore dead code and
has been since it was introduced. Drop it; the two reachable cases
(duty > target and duty < target) are unchanged, so behaviour is
identical.
Signed-off-by: Anas Khan <anxkhn28@gmail.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c
index f8fa43c8a7d2..c4aaf7473065 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c
@@ -90,8 +90,6 @@ nvkm_fan_update(struct nvkm_fan *fan, bool immediate, int target)
if (duty > target)
delay = slow_down_period;
- else if (duty == target)
- delay = min(bump_period, slow_down_period) ;
else
delay = bump_period;
--
2.54.0
reply other threads:[~2026-07-02 19:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702194540.65127-1-anxkhn28@gmail.com \
--to=anxkhn28@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®