[PATCH] selftests/filesystems: fix missing and stale TARGETS entries

[PATCH] selftests/filesystems: fix missing and stale TARGETS entries

[Disha Goel]

filesystems/eventfd, filesystems/open_tree_ns and filesystems/xattr
were never added to TARGETS when introduced. filesystems/openat2 was
moved from selftests/openat2/ but the TARGETS entry was never updated,
leaving a stale entry pointing at a directory that no longer exists.

Fix this by adding the four missing subdirectories to TARGETS and
removing the stale openat2 entry.

Fixes: 7c37857fc23a ("selftests: add eventfd selftests")
Fixes: b8f7622aa6e3 ("selftests/open_tree: add OPEN_TREE_NAMESPACE tests")
Fixes: 7e28fef5d4db ("selftests/xattr: path-based AF_UNIX socket xattr tests")
Fixes: fe087927046c ("selftests: move openat2 tests to selftests/filesystems/")
Signed-off-by: Disha Goel <disgoel@linux.ibm.com>
---
 tools/testing/selftests/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 8d4db2241cc2..4c4df65a6f91 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -33,7 +33,10 @@ TARGETS += fchmodat2
 TARGETS += filesystems
 TARGETS += filesystems/binderfs
 TARGETS += filesystems/epoll
+TARGETS += filesystems/eventfd
 TARGETS += filesystems/fat
+TARGETS += filesystems/openat2
+TARGETS += filesystems/open_tree_ns
 TARGETS += filesystems/overlayfs
 TARGETS += filesystems/statmount
 TARGETS += filesystems/mount-notify
@@ -42,6 +45,7 @@ TARGETS += filesystems/fuse
 TARGETS += filesystems/move_mount
 TARGETS += filesystems/empty_mntns
 TARGETS += filesystems/fsmount_ns
+TARGETS += filesystems/xattr
 TARGETS += firmware
 TARGETS += fpu
 TARGETS += ftrace
@@ -98,7 +102,6 @@ TARGETS += prctl
 TARGETS += proc
 TARGETS += pstore
 TARGETS += ptrace
-TARGETS += openat2
 TARGETS += rdma
 TARGETS += resctrl
 TARGETS += riscv
-- 
2.45.1

Re: [PATCH] selftests/filesystems: fix missing and stale TARGETS entries

[Christian Brauner]

> filesystems/eventfd, filesystems/open_tree_ns and filesystems/xattr
> were never added to TARGETS when introduced. filesystems/openat2 was
> moved from selftests/openat2/ but the TARGETS entry was never updated,
> leaving a stale entry pointing at a directory that no longer exists.
> 
> Fix this by adding the four missing subdirectories to TARGETS and
> removing the stale openat2 entry.
> 
> Fixes: 7c37857fc23a ("selftests: add eventfd selftests")
> Fixes: b8f7622aa6e3 ("selftests/open_tree: add OPEN_TREE_NAMESPACE tests")
> Fixes: 7e28fef5d4db ("selftests/xattr: path-based AF_UNIX socket xattr tests")
> Fixes: fe087927046c ("selftests: move openat2 tests to selftests/filesystems/")
> Signed-off-by: Disha Goel <disgoel@linux.ibm.com>

Seems fine,
Reviewed-by: Christian Brauner (Amutable) <brauner@kernel.org>

-- 
Christian Brauner <brauner@kernel.org>