From: "Mickaël Salaün" <mic@digikod.net>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
linux-kernel@vger.kernel.org,
"Nathan Chancellor" <nathan@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Bart Van Assche" <bvanassche@acm.org>,
"Günther Noack" <gnoack@google.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>
Subject: Re: [PATCH v1] clang-format: Fix formatting of guard()
Date: Wed, 8 Jul 2026 14:34:30 +0200 [thread overview]
Message-ID: <20260708.Ka2tahree8ad@digikod.net> (raw)
In-Reply-To: <CANiq72mmZF7QXdk+9s8jcWU5mfACy48gn6wZ1RZQwxaK9-03YQ@mail.gmail.com>
On Wed, Jul 08, 2026 at 01:31:47PM +0200, Miguel Ojeda wrote:
> On Wed, Jul 8, 2026 at 1:20 PM Mickaël Salaün <mic@digikod.net> wrote:
> >
> > Ok, so the guard/scoped_guard changes will disappear once you refreshed
> > the .clang-format file. This means that I should not apply the Landlock
> > changes [1] right?
>
> It would disappear, but that is why I said that we could have a
> section of the list that is for explicitly-added entries, where we
> could add `scoped_guard` back.
>
> So we could 1) apply your patch, 2) have a patch to add a new section
> of the list with the `scoped_guard` entry and a comment, 3) update the
> main list, keeping that new section below or above.
OK, that makes sense. :)
>
> (If you want to send that series, please feel free, of course!)
I guess parts 2 and 3 should probably be send for v7.13 (it's a big
patch) whereas part 1 in 7.12-rcX, so I'll let you handle that properly.
>
> Does that clarify?
Yes, thanks. I'll keep the Landlock-specific patch I sent.
>
> Having said that, `clang-format` is not enforced (unlike `rustfmt`),
> so you could apply your patch (or not) independently.
Yes, but I enforce it for Landlock, which helps a lot:
- security/landlock/
- include/uapi/linux/landlock.h
- tools/testing/selftests/landlock/
- samples/landlock/
Regards,
Mickaël
next prev parent reply other threads:[~2026-07-08 12:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 10:57 Mickaël Salaün
2026-07-08 11:06 ` Miguel Ojeda
2026-07-08 11:10 ` Mickaël Salaün
2026-07-08 11:11 ` Miguel Ojeda
2026-07-08 11:20 ` Mickaël Salaün
2026-07-08 11:31 ` Miguel Ojeda
2026-07-08 12:34 ` Mickaël Salaün [this message]
2026-07-08 12:49 ` Miguel Ojeda
2026-07-08 15:48 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708.Ka2tahree8ad@digikod.net \
--to=mic@digikod.net \
--cc=akpm@linux-foundation.org \
--cc=bvanassche@acm.org \
--cc=gnoack@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@kernel.org \
--cc=nathan@kernel.org \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome