From: "Mickaël Salaün" <mic@digikod.net>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
linux-kernel@vger.kernel.org,
"Nathan Chancellor" <nathan@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Bart Van Assche" <bvanassche@acm.org>,
"Günther Noack" <gnoack@google.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>
Subject: Re: [PATCH v1] clang-format: Fix formatting of guard()
Date: Wed, 8 Jul 2026 13:10:07 +0200 [thread overview]
Message-ID: <20260708.yi2Ve3eeGa8a@digikod.net> (raw)
In-Reply-To: <CANiq72nB6=EAeKmoWcsVR1YeUCMkFZTEdndLcSOEi1kQNPAc=w@mail.gmail.com>
On Wed, Jul 08, 2026 at 01:06:12PM +0200, Miguel Ojeda wrote:
> On Wed, Jul 8, 2026 at 12:57 PM Mickaël Salaün <mic@digikod.net> wrote:
> >
> > The previous fix was overzealous and included guard() along with
> > scoped_guard(), but only the later takes curly braces.
> >
> > The original fix introduced this issue:
> > - guard(rcu)();
> > + guard(rcu)
> > + ();
> >
> > This is especially visible with security/landlock/*.[ch] which is fully
> > formatted with clang-format.
>
> This one would go away on its own if one runs the command above from
> where the list is meant to be generated -- but `scoped_guard()` would
> be also removed.
What do you mean? Running clang-format -i security/landlock/*.[ch] does
some changes.
>
> I guess I can just have a section of explicit ones that come from
> outside the line.
>
> I can pick this one through `clang-format` and take the chance to give
> an update to the list.
Yes please.
>
> Thanks!
>
> Cheers,
> Miguel
next prev parent reply other threads:[~2026-07-08 11:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 10:57 Mickaël Salaün
2026-07-08 11:06 ` Miguel Ojeda
2026-07-08 11:10 ` Mickaël Salaün [this message]
2026-07-08 11:11 ` Miguel Ojeda
2026-07-08 11:20 ` Mickaël Salaün
2026-07-08 11:31 ` Miguel Ojeda
2026-07-08 12:34 ` Mickaël Salaün
2026-07-08 12:49 ` Miguel Ojeda
2026-07-08 15:48 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708.yi2Ve3eeGa8a@digikod.net \
--to=mic@digikod.net \
--cc=akpm@linux-foundation.org \
--cc=bvanassche@acm.org \
--cc=gnoack@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@kernel.org \
--cc=nathan@kernel.org \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome