mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@kernel.org>
To: Huisong Li <lihuisong@huawei.com>
Cc: jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org,
	Sudeep Holla <sudeep.holla@kernel.org>,
	linux-acpi@vger.kernel.org, linuxarm@huawei.com,
	zhanjie9@hisilicon.com
Subject: Re: [PATCH v2] mailbox: pcc: Fix command timeout due to missed interrupt
Date: Thu, 9 Jul 2026 13:24:10 +0100	[thread overview]
Message-ID: <20260709-thick-quirky-dog-edfcf1@sudeepholla> (raw)
In-Reply-To: <20260709114115.3113315-1-lihuisong@huawei.com>

On Thu, Jul 09, 2026 at 07:41:15PM +0800, Huisong Li wrote:
> PCC command execution can time out when a fast platform completes a
> transaction and signals the platform interrupt before pcc_send_data()
> marks the channel as in use. For shared platform interrupts, the type 3
> handler uses chan_in_use to decide whether the interrupt belongs to the
> channel. If it observes false, it ignores the completion and the caller
> waits until timeout.
> 
> Publish chan_in_use before ringing the doorbell. Use WRITE_ONCE() for
> the lockless flag update and READ_ONCE() in the interrupt handler when
> filtering shared interrupts. The following ordered MMIO accessor used for
> the doorbell keeps the earlier store visible before the platform is
> notified.
> 
> Clear chan_in_use with WRITE_ONCE() when completing the transaction,
> matching the lockless flag protocol used by the interrupt and send paths.
> 
> Fixes: 3db174e478cb ("mailbox: pcc: Support shared interrupt for multiple subspaces")
> Signed-off-by: Sudeep Holla <sudeep.holla@kernel.org>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Reviewed-by: Sudeep Holla <sudeep.holla@kernel.org>

Sorry if I gave mixed feedback, you can't have both my signoff and reviewed-by
at the same time. You need to drop one of them.

-- 
Regards,
Sudeep

  reply	other threads:[~2026-07-09 12:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09 11:41 Huisong Li
2026-07-09 12:24 ` Sudeep Holla [this message]
2026-07-09 13:17   ` lihuisong (C)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260709-thick-quirky-dog-edfcf1@sudeepholla \
    --to=sudeep.holla@kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=lihuisong@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=zhanjie9@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®