* [PATCH v2] mailbox: pcc: Fix command timeout due to missed interrupt
@ 2026-07-09 11:41 Huisong Li
2026-07-09 12:24 ` Sudeep Holla
0 siblings, 1 reply; 3+ messages in thread
From: Huisong Li @ 2026-07-09 11:41 UTC (permalink / raw)
To: sudeep.holla, jassisinghbrar, linux-kernel, linux-acpi
Cc: linuxarm, zhanjie9, lihuisong
PCC command execution can time out when a fast platform completes a
transaction and signals the platform interrupt before pcc_send_data()
marks the channel as in use. For shared platform interrupts, the type 3
handler uses chan_in_use to decide whether the interrupt belongs to the
channel. If it observes false, it ignores the completion and the caller
waits until timeout.
Publish chan_in_use before ringing the doorbell. Use WRITE_ONCE() for
the lockless flag update and READ_ONCE() in the interrupt handler when
filtering shared interrupts. The following ordered MMIO accessor used for
the doorbell keeps the earlier store visible before the platform is
notified.
Clear chan_in_use with WRITE_ONCE() when completing the transaction,
matching the lockless flag protocol used by the interrupt and send paths.
Fixes: 3db174e478cb ("mailbox: pcc: Support shared interrupt for multiple subspaces")
Signed-off-by: Sudeep Holla <sudeep.holla@kernel.org>
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Reviewed-by: Sudeep Holla <sudeep.holla@kernel.org>
---
v1->v2:
- Use WRITE/READ_ONCLE to replace smp_load_acquire/smp_store_release
v1: https://patch.msgid.link/20260417031429.2509443-1-lihuisong@huawei.com
---
drivers/mailbox/pcc.c | 39 ++++++++++++++++++++++++++-------------
1 file changed, 26 insertions(+), 13 deletions(-)
diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
index 636879ae1db7..3689706ce419 100644
--- a/drivers/mailbox/pcc.c
+++ b/drivers/mailbox/pcc.c
@@ -91,12 +91,11 @@ struct pcc_chan_reg {
* @plat_irq: platform interrupt
* @type: PCC subspace type
* @plat_irq_flags: platform interrupt flags
- * @chan_in_use: this flag is used just to check if the interrupt needs
- * handling when it is shared. Since only one transfer can occur
- * at a time and mailbox takes care of locking, this flag can be
- * accessed without a lock. Note: the type only support the
- * communication from OSPM to Platform, like type3, use it, and
- * other types completely ignore it.
+ * @chan_in_use: lockless flag used by initiator subspaces, such as type 3,
+ * to filter shared platform interrupts. Only one transfer can occur
+ * at a time, but the interrupt handler may sample the flag on another
+ * CPU, so all accesses must use READ_ONCE() or WRITE_ONCE().
+ * Other subspace types ignore it.
*/
struct pcc_chan_info {
struct pcc_mbox_chan chan;
@@ -320,8 +319,13 @@ static irqreturn_t pcc_mbox_irq(int irq, void *p)
if (pcc_chan_reg_read_modify_write(&pchan->plat_irq_ack))
return IRQ_NONE;
+ /*
+ * Master subspaces use this flag to filter shared interrupts. Use
+ * READ_ONCE() to sample the lockless flag written by pcc_send_data()
+ * on another CPU.
+ */
if (pchan->type == ACPI_PCCT_TYPE_EXT_PCC_MASTER_SUBSPACE &&
- !pchan->chan_in_use)
+ !READ_ONCE(pchan->chan_in_use))
return IRQ_NONE;
if (!pcc_mbox_cmd_complete_check(pchan))
@@ -331,12 +335,12 @@ static irqreturn_t pcc_mbox_irq(int irq, void *p)
return IRQ_NONE;
/*
- * Clear this flag after updating interrupt ack register and just
- * before mbox_chan_received_data() which might call pcc_send_data()
- * where the flag is set again to start new transfer. This is
- * required to avoid any possible race in updatation of this flag.
+ * Clear this flag after updating the interrupt ack register and just
+ * before mbox_chan_received_data(), which might call pcc_send_data()
+ * and set the flag again to start a new transfer. Use WRITE_ONCE()
+ * for the lockless update observed by the send and interrupt paths.
*/
- pchan->chan_in_use = false;
+ WRITE_ONCE(pchan->chan_in_use, false);
mbox_chan_received_data(chan, NULL);
mbox_chan_txdone(chan, 0);
@@ -438,9 +442,18 @@ static int pcc_send_data(struct mbox_chan *chan, void *data)
if (ret)
return ret;
+ /*
+ * Set chan_in_use before ringing the doorbell so a fast completion
+ * interrupt is not mistaken for a shared interrupt from another
+ * subspace. Use WRITE_ONCE() for the lockless flag update. The
+ * ordered MMIO accessor used to ring the doorbell keeps this store
+ * visible before the platform is notified.
+ */
+ if (pchan->plat_irq > 0)
+ WRITE_ONCE(pchan->chan_in_use, true);
ret = pcc_chan_reg_read_modify_write(&pchan->db);
if (!ret && pchan->plat_irq > 0)
- pchan->chan_in_use = true;
+ WRITE_ONCE(pchan->chan_in_use, false);
return ret;
}
--
2.33.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] mailbox: pcc: Fix command timeout due to missed interrupt
2026-07-09 11:41 [PATCH v2] mailbox: pcc: Fix command timeout due to missed interrupt Huisong Li
@ 2026-07-09 12:24 ` Sudeep Holla
2026-07-09 13:17 ` lihuisong (C)
0 siblings, 1 reply; 3+ messages in thread
From: Sudeep Holla @ 2026-07-09 12:24 UTC (permalink / raw)
To: Huisong Li
Cc: jassisinghbrar, linux-kernel, Sudeep Holla, linux-acpi, linuxarm,
zhanjie9
On Thu, Jul 09, 2026 at 07:41:15PM +0800, Huisong Li wrote:
> PCC command execution can time out when a fast platform completes a
> transaction and signals the platform interrupt before pcc_send_data()
> marks the channel as in use. For shared platform interrupts, the type 3
> handler uses chan_in_use to decide whether the interrupt belongs to the
> channel. If it observes false, it ignores the completion and the caller
> waits until timeout.
>
> Publish chan_in_use before ringing the doorbell. Use WRITE_ONCE() for
> the lockless flag update and READ_ONCE() in the interrupt handler when
> filtering shared interrupts. The following ordered MMIO accessor used for
> the doorbell keeps the earlier store visible before the platform is
> notified.
>
> Clear chan_in_use with WRITE_ONCE() when completing the transaction,
> matching the lockless flag protocol used by the interrupt and send paths.
>
> Fixes: 3db174e478cb ("mailbox: pcc: Support shared interrupt for multiple subspaces")
> Signed-off-by: Sudeep Holla <sudeep.holla@kernel.org>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Reviewed-by: Sudeep Holla <sudeep.holla@kernel.org>
Sorry if I gave mixed feedback, you can't have both my signoff and reviewed-by
at the same time. You need to drop one of them.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] mailbox: pcc: Fix command timeout due to missed interrupt
2026-07-09 12:24 ` Sudeep Holla
@ 2026-07-09 13:17 ` lihuisong (C)
0 siblings, 0 replies; 3+ messages in thread
From: lihuisong (C) @ 2026-07-09 13:17 UTC (permalink / raw)
To: Sudeep Holla; +Cc: jassisinghbrar, linux-kernel, linux-acpi, linuxarm, zhanjie9
On 7/9/2026 8:24 PM, Sudeep Holla wrote:
> On Thu, Jul 09, 2026 at 07:41:15PM +0800, Huisong Li wrote:
>> PCC command execution can time out when a fast platform completes a
>> transaction and signals the platform interrupt before pcc_send_data()
>> marks the channel as in use. For shared platform interrupts, the type 3
>> handler uses chan_in_use to decide whether the interrupt belongs to the
>> channel. If it observes false, it ignores the completion and the caller
>> waits until timeout.
>>
>> Publish chan_in_use before ringing the doorbell. Use WRITE_ONCE() for
>> the lockless flag update and READ_ONCE() in the interrupt handler when
>> filtering shared interrupts. The following ordered MMIO accessor used for
>> the doorbell keeps the earlier store visible before the platform is
>> notified.
>>
>> Clear chan_in_use with WRITE_ONCE() when completing the transaction,
>> matching the lockless flag protocol used by the interrupt and send paths.
>>
>> Fixes: 3db174e478cb ("mailbox: pcc: Support shared interrupt for multiple subspaces")
>> Signed-off-by: Sudeep Holla <sudeep.holla@kernel.org>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> Reviewed-by: Sudeep Holla <sudeep.holla@kernel.org>
> Sorry if I gave mixed feedback, you can't have both my signoff and reviewed-by
> at the same time. You need to drop one of them.
Sorry, will drop signoff.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-09 13:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-09 11:41 [PATCH v2] mailbox: pcc: Fix command timeout due to missed interrupt Huisong Li
2026-07-09 12:24 ` Sudeep Holla
2026-07-09 13:17 ` lihuisong (C)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®