[PATCH] iio: light: vcnl4035: Propagate regcache_sync() errors

[PATCH] iio: light: vcnl4035: Propagate regcache_sync() errors

[Pengpeng Hou]

vcnl4035_runtime_suspend() marks the regmap cache dirty before runtime
suspend. vcnl4035_runtime_resume() then syncs the cache before re-
enabling ALS, but currently ignores a regcache_sync() failure and can
still report resume success.

Return the regcache_sync() error so the PM core sees the failed register
restore.

Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
 drivers/iio/light/vcnl4035.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
index bf3a49b4351d..3ca7ccdb7f15 100644
--- a/drivers/iio/light/vcnl4035.c
+++ b/drivers/iio/light/vcnl4035.c
@@ -647,7 +647,9 @@ static int vcnl4035_runtime_resume(struct device *dev)
 	struct vcnl4035_data *data = iio_priv(indio_dev);
 	int ret;
 
-	regcache_sync(data->regmap);
+	ret = regcache_sync(data->regmap);
+	if (ret < 0)
+		return ret;
 	ret = vcnl4035_set_als_power_state(data, VCNL4035_MODE_ALS_ENABLE);
 	if (ret < 0)
 		return ret;
-- 
2.43.0

Re: [PATCH] iio: light: vcnl4035: Propagate regcache_sync() errors

[Andy Shevchenko]

On Sat, Jul 04, 2026 at 03:14:10PM +0800, Pengpeng Hou wrote:
> vcnl4035_runtime_suspend() marks the regmap cache dirty before runtime
> suspend. vcnl4035_runtime_resume() then syncs the cache before re-
> enabling ALS, but currently ignores a regcache_sync() failure and can
> still report resume success.
> 
> Return the regcache_sync() error so the PM core sees the failed register
> restore.

...

> -	regcache_sync(data->regmap);
> +	ret = regcache_sync(data->regmap);
> +	if (ret < 0)
> +		return ret;

When do like this, add a blank line.
Same comment to all similar patches you sent (or about to send).

>  	ret = vcnl4035_set_als_power_state(data, VCNL4035_MODE_ALS_ENABLE);
>  	if (ret < 0)
>  		return ret;

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: light: vcnl4035: Propagate regcache_sync() errors

[Jonathan Cameron]

On Sat, 4 Jul 2026 15:11:14 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Sat, Jul 04, 2026 at 03:14:10PM +0800, Pengpeng Hou wrote:
> > vcnl4035_runtime_suspend() marks the regmap cache dirty before runtime
> > suspend. vcnl4035_runtime_resume() then syncs the cache before re-
> > enabling ALS, but currently ignores a regcache_sync() failure and can
> > still report resume success.
> > 
> > Return the regcache_sync() error so the PM core sees the failed register
> > restore.  
> 
> ...
> 
> > -	regcache_sync(data->regmap);
> > +	ret = regcache_sync(data->regmap);
> > +	if (ret < 0)
> > +		return ret;  
> 
> When do like this, add a blank line.
> Same comment to all similar patches you sent (or about to send).
On this occasion I fixed up and applied rather than waiting for a v2.
Applied to the testing branch of iio.git.

Thanks,

Jonathan

> 
> >  	ret = vcnl4035_set_als_power_state(data, VCNL4035_MODE_ALS_ENABLE);
> >  	if (ret < 0)
> >  		return ret;  
>