From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Jason Huang <Jason.Huang2@infineon.com>
Cc: arend.vanspriel@broadcom.com,
brcm80211-dev-list.pdl@broadcom.com, brcm80211@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
Kurt Lee <kurt.lee@cypress.com>
Subject: Re: [PATCH v4] wifi: brcmfmac: add DPP support
Date: Mon, 13 Jul 2026 00:33:14 +0200 [thread overview]
Message-ID: <20260712223314.2182929-1-arend.vanspriel@broadcom.com> (raw)
In-Reply-To: <20260708071230.312836-1-Jason.Huang2@infineon.com>
On Wed, 8 Jul 2026 15:12:30 +0800, Jason Huang wrote:
> Add DPP AKM handling and RSN parsing support. Map DPP to the
> firmware wpa_auth value and recognize DPP public action frames in the
> P2P action-frame TX path.
[...]
> + p2p->bss_idx[P2PAPI_BSSCFG_DEVICE].vif &&
> p2p->bss_idx[P2PAPI_BSSCFG_DEVICE].vif->saved_ie.probe_req_ie_len) {
[...]
> ---
> .../broadcom/brcm80211/brcmfmac/cfg80211.c | 151 ++++++++++--------
> .../broadcom/brcm80211/brcmfmac/p2p.c | 59 +++++--
> .../broadcom/brcm80211/include/brcmu_wifi.h | 2 +
In the v2 review I asked to split the P2P device vif bug fix into a
separate patch with a Fixes: tag for stable backport. The null guard and
the fallback vif in brcmf_p2p_abort_action_frame() are both pre-existing
P2P bugs that should be split out and submitted as a standalone patch so
they can be backported to stable independently of the DPP feature.
Please also add a changelog below the --- line describing what changed
since v3.
Note that the P2P device vif fixes are pre-existing bugs that need to go
to the wireless tree for stable backport, separate from the DPP feature
which targets wireless-next.
Regards,
Arend
next prev parent reply other threads:[~2026-07-12 22:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260603035722.145894-1-Jason.Huang2@infineon.com>
2026-06-04 3:42 ` [PATCH v2] wifi: brcmfmac: add DPP support and fix fw-supplicant/P2P interop Jason Huang
2026-07-08 3:58 ` [PATCH v3] wifi: brcmfmac: add DPP support Jason Huang
2026-07-08 7:12 ` [PATCH v4] " Jason Huang
2026-07-12 22:33 ` Arend van Spriel [this message]
2026-07-15 9:22 ` HungTsung Huang
2026-07-15 18:46 ` Arend van Spriel
2026-07-20 18:48 ` Arend van Spriel
2026-07-15 8:47 ` [PATCH v5] " Jason Huang
2026-07-20 19:48 ` Arend van Spriel
2026-07-23 5:22 ` HungTsung Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260712223314.2182929-1-arend.vanspriel@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Jason.Huang2@infineon.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=kurt.lee@cypress.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®