* [PATCH] leds: bcm63138: Use %pe to print pinctrl error instead of %ld
@ 2026-07-13 20:07 Ninad Naik
2026-07-23 12:27 ` (subset) " Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Ninad Naik @ 2026-07-13 20:07 UTC (permalink / raw)
To: lee, pavel, william.zhang, anand.gore, kursad.oney,
florian.fainelli, rafal, linux, krzysztof.kozlowski, tzungbi
Cc: bcm-kernel-feedback-list, linux-leds, linux-arm-kernel,
linux-kernel, skhan, me, Ninad Naik
Pass the pinctrl error pointer directly to %pe to print the
symbolic error name.
Detected by Coccinelle. Tested by compiling.
Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
---
drivers/leds/blink/leds-bcm63138.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/blink/leds-bcm63138.c b/drivers/leds/blink/leds-bcm63138.c
index 45c0662df933..12b70ee31b9a 100644
--- a/drivers/leds/blink/leds-bcm63138.c
+++ b/drivers/leds/blink/leds-bcm63138.c
@@ -236,8 +236,8 @@ static void bcm63138_leds_create_led(struct bcm63138_leds *leds,
pinctrl = devm_pinctrl_get_select_default(led->cdev.dev);
if (IS_ERR(pinctrl) && PTR_ERR(pinctrl) != -ENODEV) {
- dev_warn(led->cdev.dev, "Failed to select %pOF pinctrl: %ld\n",
- np, PTR_ERR(pinctrl));
+ dev_warn(led->cdev.dev, "Failed to select %pOF pinctrl: %pe\n",
+ np, pinctrl);
}
bit = BIT(led->pin);
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: (subset) [PATCH] leds: bcm63138: Use %pe to print pinctrl error instead of %ld
2026-07-13 20:07 [PATCH] leds: bcm63138: Use %pe to print pinctrl error instead of %ld Ninad Naik
@ 2026-07-23 12:27 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2026-07-23 12:27 UTC (permalink / raw)
To: lee, pavel, william.zhang, anand.gore, kursad.oney,
florian.fainelli, rafal, linux, krzysztof.kozlowski, tzungbi,
Ninad Naik
Cc: bcm-kernel-feedback-list, linux-leds, linux-arm-kernel,
linux-kernel, skhan, me
On Tue, 14 Jul 2026 01:37:32 +0530, Ninad Naik wrote:
> Pass the pinctrl error pointer directly to %pe to print the
> symbolic error name.
> Detected by Coccinelle. Tested by compiling.
Applied, thanks!
[1/1] leds: bcm63138: Use %pe to print pinctrl error instead of %ld
commit: b6e08e0ad4cfafab2c2070456e7eeba17608a35d
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-23 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-13 20:07 [PATCH] leds: bcm63138: Use %pe to print pinctrl error instead of %ld Ninad Naik
2026-07-23 12:27 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®