From: Wanwu Li <liwanwu9113@163.com>
To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, tj@kernel.org
Cc: dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
kprateek.nayak@amd.com, linux-kernel@vger.kernel.org,
Wanwu Li <liwanwu@kylinos.cn>
Subject: [PATCH] sched/core: Fix stale se.load when modifying nice value under sched_ext
Date: Tue, 14 Jul 2026 17:13:27 +0800 [thread overview]
Message-ID: <20260714091327.3-1-liwanwu9113@163.com> (raw)
From: Wanwu Li <liwanwu@kylinos.cn>
When a task's nice value is modified while running under sched_ext
scheduling class, set_load_weight() calls reweight_task() which only
updates static_prio but leaves p->se.load unchanged because sched_ext
does not use it. After switching back to CFS, the stale se.load leads
to incorrect load weight calculation.
Fix this by explicitly refreshing p->se.load for sched_ext tasks after
calling reweight_task().
Fixes: d32960528702 ("sched/fair: set_load_weight() must also call reweight_task() for SCHED_IDLE tasks")
Signed-off-by: Wanwu Li <liwanwu@kylinos.cn>
---
kernel/sched/core.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 96226707c2f6..ebeadec41eb6 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1538,10 +1538,21 @@ void set_load_weight(struct task_struct *p, bool update_load)
* SCHED_OTHER tasks have to update their load when changing their
* weight
*/
- if (update_load && p->sched_class->reweight_task)
+ if (update_load && p->sched_class->reweight_task) {
p->sched_class->reweight_task(task_rq(p), p, &lw);
- else
+
+ /*
+ * If modify nice while task runs under ext class, only
+ * static_prio updates, p->se.load stays stale and mismatches
+ * the new nice value. After switching back to CFS, outdated
+ * load leads to incorrect weight. Synchronously refresh
+ * se.load to keep priority state consistent.
+ */
+ if (task_on_scx(p))
+ p->se.load = lw;
+ } else {
p->se.load = lw;
+ }
}
#ifdef CONFIG_UCLAMP_TASK
--
2.25.1
next reply other threads:[~2026-07-14 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 9:13 Wanwu Li [this message]
2026-07-14 9:30 ` K Prateek Nayak
2026-07-14 9:48 ` liwanwu9113
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714091327.3-1-liwanwu9113@163.com \
--to=liwanwu9113@163.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liwanwu@kylinos.cn \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®