mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: liwanwu9113 <liwanwu9113@163.com>
To: K Prateek Nayak <kprateek.nayak@amd.com>,
	mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, tj@kernel.org
Cc: dietmar.eggemann@arm.com, rostedt@goodmis.org,
	bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
	linux-kernel@vger.kernel.org, Wanwu Li <liwanwu@kylinos.cn>
Subject: Re: [PATCH] sched/core: Fix stale se.load when modifying nice value under sched_ext
Date: Tue, 14 Jul 2026 17:48:29 +0800	[thread overview]
Message-ID: <d595d040-3703-41a4-8cae-a1f0e24b82c3@163.com> (raw)
In-Reply-To: <a9be847f-4949-4a15-bd88-9abb32be3c14@amd.com>

Hello Prateek,

Thank you for your reply and correction.

I was not aware that this problem had already been addressed by another 
patch. I appreciate you taking the time to share this information. 
Please consider my patch withdrawn.

Thank you again for your guidance.

Best regards,
Wanwu Li

On 2026/7/14 17:30, K Prateek Nayak wrote:
> Hello Wanwu,
> 
> On 7/14/2026 2:43 PM, Wanwu Li wrote:
>> [You don't often get email from liwanwu9113@163.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> From: Wanwu Li <liwanwu@kylinos.cn>
>>
>> When a task's nice value is modified while running under sched_ext
>> scheduling class, set_load_weight() calls reweight_task() which only
>> updates static_prio but leaves p->se.load unchanged because sched_ext
>> does not use it. After switching back to CFS, the stale se.load leads
>> to incorrect load weight calculation.
>>
>> Fix this by explicitly refreshing p->se.load for sched_ext tasks after
>> calling reweight_task().
>>
>> Fixes: d32960528702 ("sched/fair: set_load_weight() must also call reweight_task() for SCHED_IDLE tasks")
>> Signed-off-by: Wanwu Li <liwanwu@kylinos.cn>
> 
> Isn't this solved in
> https://lore.kernel.org/lkml/20260528131238.3879110-1-quzicheng315@gmail.com/
> 


      reply	other threads:[~2026-07-14  9:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14  9:13 Wanwu Li
2026-07-14  9:30 ` K Prateek Nayak
2026-07-14  9:48   ` liwanwu9113 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d595d040-3703-41a4-8cae-a1f0e24b82c3@163.com \
    --to=liwanwu9113@163.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liwanwu@kylinos.cn \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®