From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Lin Wang <wanglin@open-hieco.net>
Cc: mario.limonciello@amd.com, Borislav Petkov <bp@alien8.de>,
tglx@kernel.org, mingo@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/6] x86/amd_nb: Restrict NB framework init to AMD vendor
Date: Tue, 14 Jul 2026 09:10:14 -0400 [thread overview]
Message-ID: <20260714131014.GC364094@yaz-khff2.amd.com> (raw)
In-Reply-To: <20260709075549.626095-3-wanglin@open-hieco.net>
On Thu, Jul 09, 2026 at 03:55:45PM +0800, Lin Wang wrote:
> Drop the X86_VENDOR_HYGON branch from init_amd_nbs() and
> early_is_amd_nb(). Both functions are entry points to the AMD NB
> framework, which uses the legacy fixed-slot PCI enumeration model
> (slot 0x18+i for node i) and the AMD-only amd_nb_misc_ids[] device-ID
> table.
>
> On Hygon Family 0x18, these paths do not find usable AMD NB entries:
> amd_cache_northbridges() probes the AMD fixed slots, while
> early_is_amd_nb() matches only AMD IDs from amd_nb_misc_ids[].
>
> Restrict these AMD framework entry points to AMD vendor. Hygon DF
> enumeration is added separately in arch/x86/kernel/hygon_node.c.
>
> No user-visible functional regression on Hygon Fam18h.
>
> amd_get_mmconfig_range() is intentionally left unchanged: it reads
> the MSR_FAM10H_MMIO_CONF_BASE shared CPU MSR and serves
> arch/x86/pci/amd_bus.c and drivers/pnp/quirks.c on Hygon platforms.
>
> Signed-off-by: Lin Wang <wanglin@open-hieco.net>
Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
Thanks,
Yazen
next prev parent reply other threads:[~2026-07-14 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 7:55 [PATCH v3 0/6] x86/hygon: Add Family 0x18 DF node enumeration and SMN access Lin Wang
2026-07-09 7:55 ` [PATCH v3 1/6] pci_ids: Add Hygon Family 0x18 DF F3/F4 device IDs Lin Wang
2026-07-09 7:55 ` [PATCH v3 2/6] x86/amd_nb: Restrict NB framework init to AMD vendor Lin Wang
2026-07-14 13:10 ` Yazen Ghannam [this message]
2026-07-09 7:55 ` [PATCH v3 3/6] x86/amd_node: Restrict SMN root enumeration " Lin Wang
2026-07-09 7:55 ` [PATCH v3 4/6] x86/hygon: Add Family 0x18 DF node enumeration Lin Wang
2026-07-09 7:55 ` [PATCH v3 5/6] x86/hygon: Add Family 0x18 SMN access Lin Wang
2026-07-09 7:55 ` [PATCH v3 6/6] x86/hygon: Add SMN debugfs interface Lin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714131014.GC364094@yaz-khff2.amd.com \
--to=yazen.ghannam@amd.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=wanglin@open-hieco.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox