* [PATCH v1 1/1] mfd: si476x-i2c: Get rid of duplicate NULL checks
@ 2026-07-15 19:16 Andy Shevchenko
0 siblings, 0 replies; only message in thread
From: Andy Shevchenko @ 2026-07-15 19:16 UTC (permalink / raw)
To: Linus Walleij, mfd, linux-kernel; +Cc: Lee Jones, Andy Shevchenko
GPIO descriptor APIs are NULL-aware and since the requested line is optional
we don't need to have an additional check each time we want to toggle GPIO.
Get rid of duplicate NULL checks.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mfd/si476x-i2c.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/si476x-i2c.c b/drivers/mfd/si476x-i2c.c
index 55700ce711f4..9bce720a0a08 100644
--- a/drivers/mfd/si476x-i2c.c
+++ b/drivers/mfd/si476x-i2c.c
@@ -130,8 +130,7 @@ int si476x_core_start(struct si476x_core *core, bool soft)
int err;
if (!soft) {
- if (core->reset)
- gpiod_set_value_cansleep(core->reset, 0);
+ gpiod_set_value_cansleep(core->reset, 0);
if (client->irq)
enable_irq(client->irq);
@@ -197,8 +196,7 @@ int si476x_core_start(struct si476x_core *core, bool soft)
else
cancel_delayed_work_sync(&core->status_monitor);
- if (core->reset)
- gpiod_set_value_cansleep(core->reset, 1);
+ gpiod_set_value_cansleep(core->reset, 1);
return err;
}
@@ -242,10 +240,9 @@ int si476x_core_stop(struct si476x_core *core, bool soft)
else
cancel_delayed_work_sync(&core->status_monitor);
- if (!soft) {
- if (core->reset)
- gpiod_set_value_cansleep(core->reset, 1);
- }
+ if (!soft)
+ gpiod_set_value_cansleep(core->reset, 1);
+
return err;
}
EXPORT_SYMBOL_GPL(si476x_core_stop);
--
2.50.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-07-15 19:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-15 19:16 [PATCH v1 1/1] mfd: si476x-i2c: Get rid of duplicate NULL checks Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome