mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lucas Martins Alves <lucas.alves@lumal21.com.br>
To: "b-liu@ti.com" <b-liu@ti.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Lucas Martins Alves <lucas.alves@lumal21.com.br>,
	Bin Liu <b-liu@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Lucas Martins Alves <lucas.alves@lumal21.com.br>
Subject: [PATCH v3 1/2] usb: musb: dsps: implement vbus_status and set_vbus platform ops
Date: Thu, 16 Jul 2026 14:25:40 +0000	[thread overview]
Message-ID: <20260716142516.510574-1-lucas.alves@lumal21.com.br> (raw)

From: Lucas Martins Alves <lucas.alves@lumal21.com.br>

The DSPS glue layer (used on TI AM335x SoCs) was missing implementations
for the vbus_status and set_vbus platform ops defined in struct
musb_platform_ops.

Add dsps_musb_vbus_status() to report VBUS presence by reading the VBUS
field of MUSB_DEVCTL, and dsps_musb_set_vbus() to drive the SESSION bit
on MUSB_DEVCTL, enabling or disabling the USB session.

Register both callbacks in dsps_ops to allow the MUSB core to control
VBUS on AM335x-based platforms. This enables the USB core to perform a
VBUS power cycle as a recovery mechanism when a USB error condition is
detected, and also allows userspace to control VBUS state via the
standard USB sysfs interface.

Signed-off-by: Lucas Martins Alves <lucas.alves@lumal21.com.br>
---
v1 -> v2:
- remove musb_root_disconnect() from set_vbus path
- adjust context->devctl copy/update handling

v2 -> v3:
- fix patch description text
- fix devctl usage in set_vbus path
---
 drivers/usb/musb/musb_dsps.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index e3935f18dd56..e3dc2b6dc9b0 100644
--- a/drivers/usb/musb/musb_dsps.c
+++ b/drivers/usb/musb/musb_dsps.c
@@ -618,6 +618,34 @@ static int dsps_musb_recover(struct musb *musb)
 	return session_restart ? 0 : -EPIPE;
 }
 
+static int dsps_musb_vbus_status(struct musb *musb)
+{
+	u8 devctl = musb_readb(musb->mregs, MUSB_DEVCTL);
+
+	return (devctl & MUSB_DEVCTL_VBUS) == MUSB_DEVCTL_VBUS;
+}
+
+static void dsps_musb_set_vbus(struct musb *musb, int is_on)
+{
+	u8 devctl;
+
+	devctl = musb_readb(musb->mregs, MUSB_DEVCTL);
+
+	if (is_on) {
+		devctl |= MUSB_DEVCTL_SESSION;
+	} else {
+		/* Since we drop the session to turn off vbus, the connection cannot survive */
+		if( musb->port1_status & USB_PORT_STAT_CONNECTION )
+			musb->port1_status |= (USB_PORT_STAT_C_CONNECTION << 16);
+		musb->port1_status &= ~( USB_PORT_STAT_CONNECTION |
+			                     USB_PORT_STAT_HIGH_SPEED |
+								 USB_PORT_STAT_LOW_SPEED );
+		devctl &= ~MUSB_DEVCTL_SESSION;
+	}
+
+	musb_writeb(musb->mregs, MUSB_DEVCTL, devctl);
+}
+
 /* Similar to am35x, dm81xx support only 32-bit read operation */
 static void dsps_read_fifo32(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
 {
@@ -702,6 +730,8 @@ static struct musb_platform_ops dsps_ops = {
 
 	.set_mode	= dsps_musb_set_mode,
 	.recover	= dsps_musb_recover,
+	.vbus_status	= dsps_musb_vbus_status,
+	.set_vbus	= dsps_musb_set_vbus,
 	.clear_ep_rxintr = dsps_musb_clear_ep_rxintr,
 };
 
-- 
2.53.0


             reply	other threads:[~2026-07-16 14:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 14:25 Lucas Martins Alves [this message]
2026-07-16 14:25 ` [PATCH v3 2/2] usb: musb: gadget: fix MUSB_DEVCTL race condition in set_vbus Lucas Martins Alves
2026-07-16 17:05 ` [PATCH v4] usb: musb: dsps: implement vbus_status and set_vbus platform ops Lucas Martins Alves
2026-07-17  9:41   ` gregkh
2026-07-17 11:29     ` Lucas Martins Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260716142516.510574-1-lucas.alves@lumal21.com.br \
    --to=lucas.alves@lumal21.com.br \
    --cc=b-liu@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox