mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Lucas Martins Alves <lucas.alves@lumal21.com.br>
Cc: "b-liu@ti.com" <b-liu@ti.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] usb: musb: dsps: implement vbus_status and set_vbus platform ops
Date: Fri, 17 Jul 2026 11:41:34 +0200	[thread overview]
Message-ID: <2026071708-tamale-regroup-2a9a@gregkh> (raw)
In-Reply-To: <20260716170551.566933-1-lucas.alves@lumal21.com.br>

On Thu, Jul 16, 2026 at 05:05:54PM +0000, Lucas Martins Alves wrote:
> From: Lucas Martins Alves <lucas.alves@lumal21.com.br>
> 
> The DSPS glue layer (used on TI AM335x SoCs) was missing implementations
> for the vbus_status and set_vbus platform ops defined in struct
> musb_platform_ops.
> 
> Add dsps_musb_vbus_status() to report VBUS presence by reading the VBUS
> field of MUSB_DEVCTL, and dsps_musb_set_vbus() to drive the SESSION bit
> on MUSB_DEVCTL, enabling or disabling the USB session.
> 
> Register both callbacks in dsps_ops to allow the MUSB core to control
> VBUS on AM335x-based platforms. This enables the USB core to perform a
> VBUS power cycle as a recovery mechanism when a USB error condition is
> detected, and also allows userspace to control VBUS state via the
> standard USB sysfs interface.
> 
> Signed-off-by: Lucas Martins Alves <lucas.alves@lumal21.com.br>
> ---
> v1 -> v2:
> - remove musb_root_disconnect() from set_vbus path
> - adjust context->devctl copy/update handling
> 
> v2 -> v3:
> - fix patch description text
> - fix devctl usage in set_vbus path
> ---
>  drivers/usb/musb/musb_dsps.c | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

I'm confused, what about patch 2?

THis series is all intermixed, can you start a new thread, and send just
what you want reviewed/accepted here?  I'm lost...

thanks,

gre k-h

  reply	other threads:[~2026-07-17  9:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 14:25 [PATCH v3 1/2] " Lucas Martins Alves
2026-07-16 14:25 ` [PATCH v3 2/2] usb: musb: gadget: fix MUSB_DEVCTL race condition in set_vbus Lucas Martins Alves
2026-07-16 17:05 ` [PATCH v4] usb: musb: dsps: implement vbus_status and set_vbus platform ops Lucas Martins Alves
2026-07-17  9:41   ` gregkh [this message]
2026-07-17 11:29     ` Lucas Martins Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026071708-tamale-regroup-2a9a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=b-liu@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lucas.alves@lumal21.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox