[PATCH 0/3] misc: Remove redundant error messages on IRQ request failure

[PATCH 0/3] misc: Remove redundant error messages on IRQ request failure

[Pan Chuang]

devm_request_threaded_irq() and devm_request_any_context_irq()
automatically log detailed error messages on failure via
the devm_request_result() helper, which prints device
name, IRQ number, handler functions, and error code.

Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.

Remove the now-redundant dev_err() and dev_err_probe() calls
in misc drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.

Pan Chuang (3):
  misc: bcm-vk: Remove redundant dev_err()
  misc: Remove redundant dev_err()/dev_err_probe()
  mei: Remove redundant dev_err()

 drivers/misc/bcm-vk/bcm_vk_dev.c | 15 +++------------
 drivers/misc/hi6421v600-irq.c    |  5 +----
 drivers/misc/mei/gsc-me.c        |  4 +---
 drivers/misc/mrvl_cn10k_dpi.c    |  4 +---
 drivers/misc/tps6594-esm.c       |  2 +-
 drivers/misc/tps6594-pfsm.c      |  2 +-
 drivers/misc/xilinx_sdfec.c      |  4 +---
 7 files changed, 9 insertions(+), 27 deletions(-)

-- 
2.34.1

[PATCH 1/3] misc: bcm-vk: Remove redundant dev_err()

[Pan Chuang]

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/misc/bcm-vk/bcm_vk_dev.c | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c
index 5773ffb46f0f..54b40b4d556d 100644
--- a/drivers/misc/bcm-vk/bcm_vk_dev.c
+++ b/drivers/misc/bcm-vk/bcm_vk_dev.c
@@ -1370,21 +1370,15 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		err = devm_request_irq(dev, pci_irq_vector(pdev, vk->num_irqs),
 				       bcm_vk_msgq_irqhandler,
 				       IRQF_SHARED, DRV_MODULE_NAME, vk);
-		if (err) {
-			dev_err(dev, "failed to request msgq IRQ %d for MSIX %d\n",
-				pdev->irq + vk->num_irqs, vk->num_irqs + 1);
+		if (err)
 			goto err_irq;
-		}
 	}
 	/* one irq for notification from VK */
 	err = devm_request_irq(dev, pci_irq_vector(pdev, vk->num_irqs),
 			       bcm_vk_notf_irqhandler,
 			       IRQF_SHARED, DRV_MODULE_NAME, vk);
-	if (err) {
-		dev_err(dev, "failed to request notf IRQ %d for MSIX %d\n",
-			pdev->irq + vk->num_irqs, vk->num_irqs + 1);
+	if (err)
 		goto err_irq;
-	}
 	vk->num_irqs++;
 
 	for (i = 0;
@@ -1393,11 +1387,8 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		err = devm_request_irq(dev, pci_irq_vector(pdev, vk->num_irqs),
 				       bcm_vk_tty_irqhandler,
 				       IRQF_SHARED, DRV_MODULE_NAME, vk);
-		if (err) {
-			dev_err(dev, "failed request tty IRQ %d for MSIX %d\n",
-				pdev->irq + vk->num_irqs, vk->num_irqs + 1);
+		if (err)
 			goto err_irq;
-		}
 		bcm_vk_tty_set_irq_enabled(vk, i);
 	}
 
-- 
2.34.1

[PATCH 2/3] misc: Remove redundant dev_err()/dev_err_probe()

[Pan Chuang]

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq()
automatically log detailed error messages on failure. Remove the
now-redundant driver-specific dev_err() and dev_err_probe() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/misc/hi6421v600-irq.c | 5 +----
 drivers/misc/mrvl_cn10k_dpi.c | 4 +---
 drivers/misc/tps6594-esm.c    | 2 +-
 drivers/misc/tps6594-pfsm.c   | 2 +-
 drivers/misc/xilinx_sdfec.c   | 4 +---
 5 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c
index 5ba40222eb12..5f65ca91b342 100644
--- a/drivers/misc/hi6421v600-irq.c
+++ b/drivers/misc/hi6421v600-irq.c
@@ -274,11 +274,8 @@ static int hi6421v600_irq_probe(struct platform_device *pdev)
 					NULL,
 					IRQF_TRIGGER_LOW | IRQF_SHARED | IRQF_NO_SUSPEND,
 					"pmic", priv);
-	if (ret < 0) {
-		dev_err(dev, "Failed to start IRQ handling thread: error %d\n",
-			ret);
+	if (ret < 0)
 		return ret;
-	}
 
 	return 0;
 }
diff --git a/drivers/misc/mrvl_cn10k_dpi.c b/drivers/misc/mrvl_cn10k_dpi.c
index 7d5433121ff6..d26c53af05eb 100644
--- a/drivers/misc/mrvl_cn10k_dpi.c
+++ b/drivers/misc/mrvl_cn10k_dpi.c
@@ -470,10 +470,8 @@ static int dpi_irq_init(struct dpipf *dpi)
 
 	ret = devm_request_irq(dev, pci_irq_vector(pdev, DPI_MBOX_PF_VF_INT_IDX),
 			       dpi_mbox_intr_handler, 0, "dpi-mbox", dpi);
-	if (ret) {
-		dev_err(dev, "DPI: request_irq failed for mbox; err=%d\n", ret);
+	if (ret)
 		return ret;
-	}
 
 	dpi_reg_write(dpi, DPI_MBOX_VF_PF_INT_ENA_W1S, GENMASK_ULL(31, 0));
 
diff --git a/drivers/misc/tps6594-esm.c b/drivers/misc/tps6594-esm.c
index 2fbd3fbdf713..50e121669c6d 100644
--- a/drivers/misc/tps6594-esm.c
+++ b/drivers/misc/tps6594-esm.c
@@ -62,7 +62,7 @@ static int tps6594_esm_probe(struct platform_device *pdev)
 						tps6594_esm_isr, IRQF_ONESHOT,
 						pdev->resource[i].name, pdev);
 		if (ret)
-			return dev_err_probe(dev, ret, "Failed to request irq\n");
+			return ret;
 	}
 
 	ret = regmap_set_bits(tps->regmap, TPS6594_REG_ESM_SOC_MODE_CFG,
diff --git a/drivers/misc/tps6594-pfsm.c b/drivers/misc/tps6594-pfsm.c
index 44fa81d6cec2..c3a0d6367f2c 100644
--- a/drivers/misc/tps6594-pfsm.c
+++ b/drivers/misc/tps6594-pfsm.c
@@ -308,7 +308,7 @@ static int tps6594_pfsm_probe(struct platform_device *pdev)
 						tps6594_pfsm_isr, IRQF_ONESHOT,
 						pdev->resource[i].name, pdev);
 		if (ret)
-			return dev_err_probe(dev, ret, "Failed to request irq\n");
+			return ret;
 	}
 
 	platform_set_drvdata(pdev, pfsm);
diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
index 3135ba3a58ee..fe7bea3b14bf 100644
--- a/drivers/misc/xilinx_sdfec.c
+++ b/drivers/misc/xilinx_sdfec.c
@@ -1390,10 +1390,8 @@ static int xsdfec_probe(struct platform_device *pdev)
 		err = devm_request_threaded_irq(dev, xsdfec->irq, NULL,
 						xsdfec_irq_thread, IRQF_ONESHOT,
 						"xilinx-sdfec16", xsdfec);
-		if (err < 0) {
-			dev_err(dev, "unable to request IRQ%d", xsdfec->irq);
+		if (err < 0)
 			goto err_xsdfec_dev;
-		}
 	}
 
 	err = ida_alloc(&dev_nrs, GFP_KERNEL);
-- 
2.34.1

[PATCH 3/3] mei: Remove redundant dev_err()

[Pan Chuang]

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/misc/mei/gsc-me.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c
index 73d5beeb9c34..376840b2c354 100644
--- a/drivers/misc/mei/gsc-me.c
+++ b/drivers/misc/mei/gsc-me.c
@@ -101,10 +101,8 @@ static int mei_gsc_probe(struct auxiliary_device *aux_dev,
 						mei_me_irq_quick_handler,
 						mei_me_irq_thread_handler,
 						IRQF_ONESHOT, KBUILD_MODNAME, dev);
-		if (ret) {
-			dev_err(device, "irq register failed %d\n", ret);
+		if (ret)
 			goto err;
-		}
 	}
 
 	ret = mei_register(dev, device);
-- 
2.34.1