mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yousef Alhouseen <alhouseenyousef@gmail.com>
Cc: Alexander Graf <graf@amazon.com>,
	The AWS Nitro Enclaves Team <aws-nitro-enclaves-devel@amazon.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio: nsm: fix raw ioctl copy error path
Date: Fri, 17 Jul 2026 13:14:37 +0200	[thread overview]
Message-ID: <2026071716-reshoot-subsidize-98bf@gregkh> (raw)
In-Reply-To: <20260624173501.4094-1-alhouseenyousef@gmail.com>

On Wed, Jun 24, 2026 at 07:35:01PM +0200, Yousef Alhouseen wrote:
> nsm_dev_ioctl() uses a common exit path which unlocks nsm->lock.
> 
> A failed copy_from_user() reaches that path before the mutex is locked.
> 
> Return -EFAULT directly for that pre-lock failure.
> 
> Signed-off-by: Yousef Alhouseen <alhouseenyousef@gmail.com>
> ---
>  drivers/misc/nsm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

The subject says "virtio" yet that is not what this driver is :(

Can you fix that up and resend?

thanks,

greg k-h

  parent reply	other threads:[~2026-07-17 11:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24 17:35 Yousef Alhouseen
2026-06-25  5:40 ` Arnd Bergmann
2026-07-17 11:14 ` Greg Kroah-Hartman [this message]
2026-07-18 12:20   ` Yousef Alhouseen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026071716-reshoot-subsidize-98bf@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=alhouseenyousef@gmail.com \
    --cc=arnd@arndb.de \
    --cc=aws-nitro-enclaves-devel@amazon.com \
    --cc=graf@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome