* Re: [PATCH] mm/damon/ops-common: remove redundant local variable in damon_migrate_folio_list()
[not found] <20260718002125.637104-1-lienze@kylinos.cn>
@ 2026-07-18 1:06 ` SJ Park
0 siblings, 0 replies; only message in thread
From: SJ Park @ 2026-07-18 1:06 UTC (permalink / raw)
To: Enze Li; +Cc: SJ Park, akpm, damon, linux-mm, enze.li, linux-kernel
Hello Enze,
get_maintainer.pl suggests to Cc linux-kernel@vger.kernel.org too. Adding it
to Cc list.
On Sat, 18 Jul 2026 08:21:25 +0800 Enze Li <lienze@kylinos.cn> wrote:
> In damon_migrate_folio_list(), we're redeclaring folio inside the first
> while loop, but it just shadows the outer one. Since the second loop
> uses the outer folio anyway, the inner declaration is pointless.
>
> Remove it to consistently reuse the same variable throughout the
> function and improve readability.
Nice catch!
>
> Signed-off-by: Enze Li <lienze@kylinos.cn>
Reviewed-by: SJ Park <sj@kernel.org>
This patch is applied to damon/next [1] tree. If this patch is not added to
mm.git in short term (~1 week?), I will ask mm.git maintainer (Andrew Morton)
to pick this. So, no action from your side is needed for now. If it seems I
also forgot doing that or you cannot wait for my action, please feel free to
directly ask that to Andrew.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] only message in thread