From: Pan Chuang <panchuang@vivo.com>
To: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org (open list:LM90 HARDWARE MONITOR
DRIVER), linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH v2 3/7] hwmon: (lm90) Remove redundant dev_err()
Date: Mon, 20 Jul 2026 14:37:37 +0800 [thread overview]
Message-ID: <20260720063745.309331-4-panchuang@vivo.com> (raw)
In-Reply-To: <20260720063745.309331-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/hwmon/lm90.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
index 4b9c0ccdf260..348eea5bec3f 100644
--- a/drivers/hwmon/lm90.c
+++ b/drivers/hwmon/lm90.c
@@ -2918,10 +2918,8 @@ static int lm90_probe(struct i2c_client *client)
err = devm_request_threaded_irq(dev, client->irq,
NULL, lm90_irq_thread,
IRQF_ONESHOT, "lm90", client);
- if (err < 0) {
- dev_err(dev, "cannot request IRQ %d\n", client->irq);
+ if (err < 0)
return err;
- }
}
return 0;
--
2.34.1
next prev parent reply other threads:[~2026-07-20 6:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 6:37 [PATCH v2 0/7] hwmon: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-20 6:37 ` [PATCH v2 1/7] hwmon: (axi-fan-control) Remove redundant dev_err_probe() Pan Chuang
2026-07-20 14:32 ` Guenter Roeck
2026-07-20 6:37 ` [PATCH v2 2/7] hwmon: (da9055) Remove redundant dev_err() Pan Chuang
2026-07-20 14:33 ` Guenter Roeck
2026-07-20 6:37 ` Pan Chuang [this message]
2026-07-20 14:33 ` [PATCH v2 3/7] hwmon: (lm90) " Guenter Roeck
2026-07-20 6:37 ` [PATCH v2 4/7] hwmon: (npcm750-pwm-fan) " Pan Chuang
2026-07-20 14:34 ` Guenter Roeck
2026-07-20 6:37 ` [PATCH v2 5/7] hwmon: (pwm-fan) " Pan Chuang
2026-07-20 14:35 ` Guenter Roeck
2026-07-20 6:37 ` [PATCH v2 6/7] hwmon: (sht15) " Pan Chuang
2026-07-20 14:35 ` Guenter Roeck
2026-07-20 6:37 ` [PATCH v2 7/7] hwmon: (pmbus) " Pan Chuang
2026-07-20 14:36 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720063745.309331-4-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®