From: Pan Chuang <panchuang@vivo.com>
To: Andrew Jeffery <andrew@codeconstruct.com.au>,
Avi Fishman <avifishman70@gmail.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Tali Perry <tali.perry1@gmail.com>,
Patrick Venture <venture@google.com>,
Nancy Yuen <yuenn@google.com>,
Benjamin Fair <benjaminfair@google.com>,
Guenter Roeck <linux@roeck-us.net>,
openbmc@lists.ozlabs.org (moderated list:ARM/NUVOTON NPCM
ARCHITECTURE),
linux-hwmon@vger.kernel.org (open list:HARDWARE MONITORING),
linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH v2 4/7] hwmon: (npcm750-pwm-fan) Remove redundant dev_err()
Date: Mon, 20 Jul 2026 14:37:38 +0800 [thread overview]
Message-ID: <20260720063745.309331-5-panchuang@vivo.com> (raw)
In-Reply-To: <20260720063745.309331-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs detailed
error messages on failure. Remove the now-redundant driver-specific
dev_err() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/hwmon/npcm750-pwm-fan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hwmon/npcm750-pwm-fan.c b/drivers/hwmon/npcm750-pwm-fan.c
index aea0b8659f5f..df24dec78e77 100644
--- a/drivers/hwmon/npcm750-pwm-fan.c
+++ b/drivers/hwmon/npcm750-pwm-fan.c
@@ -991,10 +991,8 @@ static int npcm7xx_pwm_fan_probe(struct platform_device *pdev)
sprintf(name, "NPCM7XX-FAN-MD%d", i);
ret = devm_request_irq(dev, data->fan_irq[i], npcm7xx_fan_isr,
0, name, (void *)data);
- if (ret) {
- dev_err(dev, "register IRQ fan%d failed\n", i);
+ if (ret)
return ret;
- }
}
for_each_child_of_node_scoped(np, child) {
--
2.34.1
next prev parent reply other threads:[~2026-07-20 6:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 6:37 [PATCH v2 0/7] hwmon: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-20 6:37 ` [PATCH v2 1/7] hwmon: (axi-fan-control) Remove redundant dev_err_probe() Pan Chuang
2026-07-20 14:32 ` Guenter Roeck
2026-07-20 6:37 ` [PATCH v2 2/7] hwmon: (da9055) Remove redundant dev_err() Pan Chuang
2026-07-20 14:33 ` Guenter Roeck
2026-07-20 6:37 ` [PATCH v2 3/7] hwmon: (lm90) " Pan Chuang
2026-07-20 14:33 ` Guenter Roeck
2026-07-20 6:37 ` Pan Chuang [this message]
2026-07-20 14:34 ` [PATCH v2 4/7] hwmon: (npcm750-pwm-fan) " Guenter Roeck
2026-07-20 6:37 ` [PATCH v2 5/7] hwmon: (pwm-fan) " Pan Chuang
2026-07-20 14:35 ` Guenter Roeck
2026-07-20 6:37 ` [PATCH v2 6/7] hwmon: (sht15) " Pan Chuang
2026-07-20 14:35 ` Guenter Roeck
2026-07-20 6:37 ` [PATCH v2 7/7] hwmon: (pmbus) " Pan Chuang
2026-07-20 14:36 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720063745.309331-5-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=andrew@codeconstruct.com.au \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®