mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Eli Billauer <eli.billauer@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/7] char: xillybus: Harden driver and improve code quality
Date: Wed, 22 Jul 2026 18:00:22 +0200	[thread overview]
Message-ID: <2026072212-fernlike-junkyard-461d@gregkh> (raw)
In-Reply-To: <ea1f97d4-b51d-1587-b18a-539c72fc0eed@outbound.gmail.com>

On Wed, Jul 22, 2026 at 05:53:14PM +0200, Eli Billauer wrote:
> On 22/07/2026 16:49, Jonathan Corbet wrote:
> > Eli Billauer <eli.billauer@gmail.com> writes:
> > 
> > > This patch set consists of several boundary and sanity checks, gaining
> > > better control of execution flow and fixing minor coding issues. No
> > > difference is expected in the driver's behavior under normal conditions,
> > > except for one change that might improve bandwidth performance
> > > marginally.
> > > 
> > > These patches are the result of a comprehensive AI-assisted code review,
> > > using Deepseek, Kimi Thinking K2.6, ChatGPT, and Claude Sonnet 4.6 as
> > > plain prompt tools.
> > 
> > So it would seem that they need Assisted-by tags?
> > 
> 
> Frankly speaking, I don't know. And I'll explain the dilemma:
> 
> As I wrote in the v1 cover letter (and removed for v2, which I perhaps
> shouldn't have done), my work with the AI tools was what I call a "reverse
> rubber duck" session: the AI tools told me what they considered to be a bug,
> and my job was to convince the rubber duck that it was wrong. And this went
> on for three weeks.
> 
> In a few cases, the rubber duck actually had a point. In most cases, it
> merely got me to pay attention to things I didn't notice before. And the
> actual corrections were written by me: the suggestions made by AI were a
> long way from being usable.
> 
> I understand that Assisted-by tags are intended to keep track of how AI is
> used for contributing to the Linux kernel. But I'm not sure my case is what
> this tag was meant for. Plus, as this went on for quite a while, I don't
> have a record of which tool contributed to which patch. So mention all four
> for all patches?
> 
> So I'll have to bounce the question back: Is the Assisted-by tag suitable
> when AI acts as a rubber duck?

Yes.  Please add something there.

thanks,

greg k-h

      reply	other threads:[~2026-07-22 16:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 10:23 Eli Billauer
2026-07-22 10:23 ` [PATCH v2 1/7] char: xillybus: Improve control of execution flow with mutexes Eli Billauer
2026-07-22 10:23 ` [PATCH v2 2/7] char: xillybus: Remove duplicate error path code Eli Billauer
2026-07-22 10:23 ` [PATCH v2 3/7] char: xillybus: Avoid possible bandwidth inefficiency Eli Billauer
2026-07-22 10:23 ` [PATCH v2 4/7] char: xillybus: Use unsigned arithmetic for jiffies differences Eli Billauer
2026-07-22 10:23 ` [PATCH v2 5/7] char: xillybus: Integer arithmetic improvements Eli Billauer
2026-07-22 10:23 ` [PATCH v2 6/7] char: xillybus: Add defensive sanity checks Eli Billauer
2026-07-22 10:23 ` [PATCH v2 7/7] char: xillybus: Ignore and report unsolicited interrupts Eli Billauer
2026-07-22 14:49 ` [PATCH v2 0/7] char: xillybus: Harden driver and improve code quality Jonathan Corbet
2026-07-22 15:53   ` Eli Billauer
2026-07-22 16:00     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026072212-fernlike-junkyard-461d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=eli.billauer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®