* [PATCH v2] pinctrl: s32cc: fix unmet dependency for PINCTRL_S32CC
@ 2026-07-22 21:33 Julian Braha
2026-07-25 9:48 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Julian Braha @ 2026-07-22 21:33 UTC (permalink / raw)
To: aisheng.dong, festevam, Frank.Li, ping.bai, linusw
Cc: chester62515, mbrugger, ghennadi.procopciuc, s32, kernel,
bartosz.golaszewski, andrei.stefanescu,
khristineandreea.barbulescu, arnd, linux-kernel, linux-gpio,
linux-arm-kernel, Julian Braha
Currently, PINCTRL_S32G2 selects PINCTRL_S32CC which needs GPIOLIB, without
selecting or depending on GPIOLIB.
However, other similar options in this subsystem actually select GPIOLIB
instead of depending, so I think we can do the same here.
This unmet dependency was found by kconfirm, a static analysis tool for
Kconfig.
Fixes: 94cb9e8f2707 ("pinctrl: s32cc: implement GPIO functionality")
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
v2: fix typo in commit message PINCTRL_S32CC -> PINCTRL_S32G2
Link to v1:
https://lore.kernel.org/all/20260722202638.135277-1-julianbraha@gmail.com/
---
drivers/pinctrl/nxp/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/nxp/Kconfig b/drivers/pinctrl/nxp/Kconfig
index 711c0fe11565..fab725f250ab 100644
--- a/drivers/pinctrl/nxp/Kconfig
+++ b/drivers/pinctrl/nxp/Kconfig
@@ -1,10 +1,11 @@
# SPDX-License-Identifier: GPL-2.0-only
config PINCTRL_S32CC
bool
- depends on ARCH_S32 && OF && GPIOLIB
+ depends on ARCH_S32 && OF
select GENERIC_PINCTRL_GROUPS
select GENERIC_PINMUX_FUNCTIONS
select GENERIC_PINCONF
+ select GPIOLIB
select GPIO_REGMAP
select REGMAP_MMIO
--
2.54.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] pinctrl: s32cc: fix unmet dependency for PINCTRL_S32CC
2026-07-22 21:33 [PATCH v2] pinctrl: s32cc: fix unmet dependency for PINCTRL_S32CC Julian Braha
@ 2026-07-25 9:48 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2026-07-25 9:48 UTC (permalink / raw)
To: Julian Braha
Cc: aisheng.dong, festevam, Frank.Li, ping.bai, chester62515,
mbrugger, ghennadi.procopciuc, s32, kernel, bartosz.golaszewski,
andrei.stefanescu, khristineandreea.barbulescu, arnd,
linux-kernel, linux-gpio, linux-arm-kernel
On Wed, Jul 22, 2026 at 11:33 PM Julian Braha <julianbraha@gmail.com> wrote:
> Currently, PINCTRL_S32G2 selects PINCTRL_S32CC which needs GPIOLIB, without
> selecting or depending on GPIOLIB.
>
> However, other similar options in this subsystem actually select GPIOLIB
> instead of depending, so I think we can do the same here.
>
> This unmet dependency was found by kconfirm, a static analysis tool for
> Kconfig.
>
> Fixes: 94cb9e8f2707 ("pinctrl: s32cc: implement GPIO functionality")
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-25 9:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-22 21:33 [PATCH v2] pinctrl: s32cc: fix unmet dependency for PINCTRL_S32CC Julian Braha
2026-07-25 9:48 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome