mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/msm: remove objects from evit list after pinning them
@ 2026-07-23 18:59 Anna Maniscalco
  2026-07-23 19:06 ` Rob Clark
  0 siblings, 1 reply; 2+ messages in thread
From: Anna Maniscalco @ 2026-07-23 18:59 UTC (permalink / raw)
  To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
	Sean Paul, Marijn Suijten, David Airlie, Simona Vetter
  Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Anna Maniscalco

Once objects are pinned they should not be kept in the evict list as
that will cause drm_gpuvm_validate to keep ieterating a growing list of
objects needlessly.

Once an object is pinned remove it from the list.

Signed-off-by: Anna Maniscalco <anna.maniscalco2000@gmail.com>
---
 drivers/gpu/drm/msm/msm_gem_vma.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c
index 1a952b171ed7..4422677f095c 100644
--- a/drivers/gpu/drm/msm/msm_gem_vma.c
+++ b/drivers/gpu/drm/msm/msm_gem_vma.c
@@ -458,6 +458,8 @@ msm_gem_vm_bo_validate(struct drm_gpuvm_bo *vm_bo, struct drm_exec *exec)
 			return ret;
 	}
 
+	drm_gpuvm_bo_evict(vm_bo, false);
+
 	return 0;
 }
 

---
base-commit: 9a967125427e03c7ebc24d7ad26e9307e8403d4e
change-id: 20260723-evict_list_fix-1da92b2627aa

Best regards,
--  
Anna Maniscalco <anna.maniscalco2000@gmail.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/msm: remove objects from evit list after pinning them
  2026-07-23 18:59 [PATCH] drm/msm: remove objects from evit list after pinning them Anna Maniscalco
@ 2026-07-23 19:06 ` Rob Clark
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Clark @ 2026-07-23 19:06 UTC (permalink / raw)
  To: Anna Maniscalco
  Cc: Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
	Marijn Suijten, David Airlie, Simona Vetter, linux-arm-msm,
	dri-devel, freedreno, linux-kernel

On Thu, Jul 23, 2026 at 12:00 PM Anna Maniscalco
<anna.maniscalco2000@gmail.com> wrote:
>
> Once objects are pinned they should not be kept in the evict list as
> that will cause drm_gpuvm_validate to keep ieterating a growing list of
> objects needlessly.
>
> Once an object is pinned remove it from the list.
>

Fixes: 2e6a8a1fe2b2 ("drm/msm: Add VM_BIND ioctl")

> Signed-off-by: Anna Maniscalco <anna.maniscalco2000@gmail.com>
> ---
>  drivers/gpu/drm/msm/msm_gem_vma.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c
> index 1a952b171ed7..4422677f095c 100644
> --- a/drivers/gpu/drm/msm/msm_gem_vma.c
> +++ b/drivers/gpu/drm/msm/msm_gem_vma.c
> @@ -458,6 +458,8 @@ msm_gem_vm_bo_validate(struct drm_gpuvm_bo *vm_bo, struct drm_exec *exec)
>                         return ret;
>         }
>
> +       drm_gpuvm_bo_evict(vm_bo, false);
> +
>         return 0;
>  }
>
>
> ---
> base-commit: 9a967125427e03c7ebc24d7ad26e9307e8403d4e
> change-id: 20260723-evict_list_fix-1da92b2627aa
>
> Best regards,
> --
> Anna Maniscalco <anna.maniscalco2000@gmail.com>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-23 19:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-23 18:59 [PATCH] drm/msm: remove objects from evit list after pinning them Anna Maniscalco
2026-07-23 19:06 ` Rob Clark

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®