From: Christoph Hellwig <hch@lst.de>
To: "Zhou, Yun" <yun.zhou@windriver.com>
Cc: Christoph Hellwig <hch@lst.de>,
cem@kernel.org, djwong@kernel.org, willy@infradead.org,
akpm@linux-foundation.org, hwenwur@gmail.com,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] xfs: restore nofs context unconditionally in xfs_trans_roll
Date: Fri, 24 Jul 2026 07:27:15 +0200 [thread overview]
Message-ID: <20260724052715.GA4181@lst.de> (raw)
In-Reply-To: <f7e7b1f9-ddee-4668-9cea-830264f984f5@windriver.com>
On Fri, Jul 24, 2026 at 12:08:33PM +0800, Zhou, Yun wrote:
>> Having a maze of single or two caller magic macros that modify global
>> (or rather global-ish as it's per thread) state makes hairy bits like
>> this really error prone as seen by the bugs now found.
>
> It's been a few days since the last discussion. I'm planning to
> respin as v3 following Christoph's suggestion (drop the helper,
> re-save directly in xfs_trans_roll). Any other suggestions?
Sounds good to me.
prev parent reply other threads:[~2026-07-24 5:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 9:57 [PATCH v2 0/2] " Yun Zhou
2026-07-19 9:57 ` [PATCH v2 1/2] mm: introduce memalloc_flags_move() for transferring allocation scopes Yun Zhou
2026-07-19 20:57 ` Andrew Morton
2026-07-20 4:43 ` Zhou, Yun
2026-07-19 9:57 ` [PATCH v2 2/2] xfs: restore nofs context unconditionally in xfs_trans_roll Yun Zhou
2026-07-20 8:39 ` Christoph Hellwig
2026-07-24 4:08 ` Zhou, Yun
2026-07-24 5:27 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724052715.GA4181@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hwenwur@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
--cc=yun.zhou@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome