mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Cen Zhang <zzzccc427@gmail.com>
Cc: Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
	Joseph Qi <joseph.qi@linux.alibaba.com>,
	ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
	baijiaju1990@gmail.com
Subject: Re: [PATCH 0/2] ocfs2: harden heartbeat teardown races
Date: Sat, 25 Jul 2026 21:02:17 -0700	[thread overview]
Message-ID: <20260725210217.8880c2417a832cad67b0d9d2@linux-foundation.org> (raw)
In-Reply-To: <20260624095310.763763-1-zzzccc427@gmail.com>

On Wed, 24 Jun 2026 17:53:08 +0800 Cen Zhang <zzzccc427@gmail.com> wrote:

> This series fixes two OCFS2 heartbeat/o2net teardown races found by
> KASAN.

Thanks.

Having two Fixes: on [2/2] is quite confusing.  Fixes: tells -stable
maintainers "add this patch to this kernel version".  So what are they
to make of this conflicting advice?

But both Fixes: targets are from 2016 so it doesn't matter.  I'm assuming
we don't need cc:stable on these, but that might be wrong?


I'd really like to see Sashiko review on this series, but
https://sashiko.dev/#/patchset/20260624095310.763763-1-zzzccc427@gmail.com
says "failed to apply".  

I don't know what its problem is.  It tries linux-next and
ocfs2-cluster-keep-heartbeat-local-node-stable.patch has been in
linux-next for over a week and both patches apply cleanly to linux-next
for me.

It's a shame, because these are two quite large and complex patches to
old and very tricky code which hasn't proven to be problem-free in
recent times!

Sigh.  I'll poke Roman, see if there's something that can be done
longer-term to improve the situation.  Meanwhile, Joseph, are you
really sure?

  parent reply	other threads:[~2026-07-26  4:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24  9:53 Cen Zhang
2026-06-24  9:53 ` [PATCH 1/2] ocfs2: synchronize heartbeat callbacks with o2net teardown Cen Zhang
2026-07-24  1:40   ` Joseph Qi
2026-06-24  9:53 ` [PATCH 2/2] ocfs2: o2hb: quiesce negotiate handlers and timeout work Cen Zhang
2026-07-24  1:41   ` Joseph Qi
2026-07-06  8:56 ` [PATCH 0/2] ocfs2: harden heartbeat teardown races Cen Zhang
2026-07-26  4:02 ` Andrew Morton [this message]
2026-07-26  6:58   ` Joseph Qi
2026-07-27  3:13     ` Cen Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260725210217.8880c2417a832cad67b0d9d2@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=baijiaju1990@gmail.com \
    --cc=jlbec@evilplan.org \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@lists.linux.dev \
    --cc=zzzccc427@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®