Re: [PATCH 0/2] ocfs2: harden heartbeat teardown races

[Joseph Qi <joseph.qi@linux.alibaba.com>]

On 7/26/26 12:02 PM, Andrew Morton wrote:
> On Wed, 24 Jun 2026 17:53:08 +0800 Cen Zhang <zzzccc427@gmail.com> wrote:
> 
>> This series fixes two OCFS2 heartbeat/o2net teardown races found by
>> KASAN.
> 
> Thanks.
> 
> Having two Fixes: on [2/2] is quite confusing.  Fixes: tells -stable
> maintainers "add this patch to this kernel version".  So what are they
> to make of this conflicting advice?
> 
> But both Fixes: targets are from 2016 so it doesn't matter.  I'm assuming
> we don't need cc:stable on these, but that might be wrong?
> 

I'd prefer not cc stable since it introduce a reconstruction.

> 
> I'd really like to see Sashiko review on this series, but
> https://sashiko.dev/#/patchset/20260624095310.763763-1-zzzccc427@gmail.com
> says "failed to apply".  
> 

Not sure how it conflicts. The 2 patches can be applied cleanly in my
devel tree, on top of my o2hb_region_pin fixes.

Cen, could you please verify it on the latest linux-next?

Thanks,
Joseph

> I don't know what its problem is.  It tries linux-next and
> ocfs2-cluster-keep-heartbeat-local-node-stable.patch has been in
> linux-next for over a week and both patches apply cleanly to linux-next
> for me.
> 
> It's a shame, because these are two quite large and complex patches to
> old and very tricky code which hasn't proven to be problem-free in
> recent times!
> 
> Sigh.  I'll poke Roman, see if there's something that can be done
> longer-term to improve the situation.  Meanwhile, Joseph, are you
> really sure?