mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] exfat: write moved entry before removing source
@ 2026-07-27  9:12 Yichong Chen
  2026-07-28  4:54 ` Namjae Jeon
  0 siblings, 1 reply; 2+ messages in thread
From: Yichong Chen @ 2026-07-27  9:12 UTC (permalink / raw)
  To: linkinjeon, sj1557.seo; +Cc: yuezhang.mo, exfat, linux-kernel, Yichong Chen

exfat_move_file() removes the old directory entry before the new entry
has been written.  If writing the new entry fails, rename returns an
error after the source entry has already been marked deleted.

Write the new entry first, then remove the old entry and update the
cached inode location.  This keeps the source entry intact if creating
the destination entry fails.

Signed-off-by: Yichong Chen <chenyichong@uniontech.com>
---
 fs/exfat/namei.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c
index cd9c9eca58f8..038bc6fed681 100644
--- a/fs/exfat/namei.c
+++ b/fs/exfat/namei.c
@@ -1116,11 +1116,6 @@ static int exfat_move_file(struct inode *parent_inode,
 	exfat_init_ext_entry(&new_es, num_new_entries, p_uniname,
 			     &mov_es, num_extra_entries);
 
-	exfat_remove_entries(parent_inode, &mov_es, ES_IDX_FILE, false);
-
-	ei->dir = newdir;
-	ei->entry = newentry;
-
 	ret = exfat_put_dentry_set(&new_es, IS_DIRSYNC(parent_inode));
 	if (ret) {
 		/* Best-effort delete to avoid duplicate entries */
@@ -1134,6 +1129,11 @@ static int exfat_move_file(struct inode *parent_inode,
 		goto put_mov_es;
 	}
 
+	exfat_remove_entries(parent_inode, &mov_es, ES_IDX_FILE, false);
+
+	ei->dir = newdir;
+	ei->entry = newentry;
+
 	return exfat_put_dentry_set(&mov_es, IS_DIRSYNC(parent_inode));
 
 put_mov_es:
-- 
2.51.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] exfat: write moved entry before removing source
  2026-07-27  9:12 [PATCH] exfat: write moved entry before removing source Yichong Chen
@ 2026-07-28  4:54 ` Namjae Jeon
  0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2026-07-28  4:54 UTC (permalink / raw)
  To: Yichong Chen; +Cc: sj1557.seo, yuezhang.mo, exfat, linux-kernel

On Mon, Jul 27, 2026 at 6:12 PM Yichong Chen <chenyichong@uniontech.com> wrote:
>
> exfat_move_file() removes the old directory entry before the new entry
> has been written.  If writing the new entry fails, rename returns an
> error after the source entry has already been marked deleted.
>
> Write the new entry first, then remove the old entry and update the
> cached inode location.  This keeps the source entry intact if creating
> the destination entry fails.
>
> Signed-off-by: Yichong Chen <chenyichong@uniontech.com>
Applied it to #dev.
Thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-28  4:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-27  9:12 [PATCH] exfat: write moved entry before removing source Yichong Chen
2026-07-28  4:54 ` Namjae Jeon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®