mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Ramin Moussavi <ramin.moussavi@yacoub.de>
Cc: Michal Simek <monstr@monstr.eu>, Mike Rapoport <rppt@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] microblaze: restore the page alignment of swapper_pg_dir
Date: Mon, 27 Jul 2026 18:06:38 -0700	[thread overview]
Message-ID: <20260727180638.99406eb86b56c8c3283383f5@linux-foundation.org> (raw)
In-Reply-To: <20260727215823.1422701-1-ramin.moussavi@yacoub.de>

On Mon, 27 Jul 2026 23:58:23 +0200 Ramin Moussavi <ramin.moussavi@yacoub.de> wrote:

> microblaze handles TLB misses in software, and the handler builds the
> address of the L1 entry by ORing the index into the page directory base
> instead of adding it (hw_exception_handler.S):
> 

Well that was a convincing changelog.

> 
> Fixes: 6215d9f4470f ("arch, mm: consolidate empty_zero_page")

I'll queue for 7.2-rcX.

> Cc: stable@vger.kernel.org

With this.

> --- a/arch/microblaze/kernel/head.S
> +++ b/arch/microblaze/kernel/head.S
> @@ -39,6 +39,8 @@
>  #include <asm/processor.h>
>  
>  .section .data
> +/* The MMU requires a page aligned page directory. */
> +.align 12
>  .global swapper_pg_dir
>  swapper_pg_dir:
>  	.space	PAGE_SIZE

Thanks.

Hard-coding "12" is a bit sad.  Can we do ".align PAGE_SHIFT" or
similar?

  reply	other threads:[~2026-07-28  1:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 21:58 Ramin Moussavi
2026-07-28  1:06 ` Andrew Morton [this message]
2026-07-28  5:28 ` Michal Simek
2026-07-28  6:24   ` Guenter Roeck
2026-07-28  7:11     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727180638.99406eb86b56c8c3283383f5@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monstr@monstr.eu \
    --cc=ramin.moussavi@yacoub.de \
    --cc=rppt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®