* [PATCH] ARM: dts: BCM5301X: Add missing phy-mode and fixed-link to DSA switch ports
@ 2026-07-27 22:17 Rosen Penev
2026-07-30 23:26 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-07-27 22:17 UTC (permalink / raw)
To: devicetree
Cc: Florian Fainelli, Hauke Mehrtens, Rafał Miłecki,
Broadcom internal kernel review list, Rob Herring,
Krzysztof Kozlowski, Conor Dooley,
moderated list:BROADCOM BCM5301X ARM ARCHITECTURE, open list
Ports 5, 7 and 8 in the BCM5301x SRAB switch node carry an 'ethernet'
property linking them to GMACs, but lack the required 'phy-mode' and
'fixed-link' properties. The DSA port schema (dsa-port.yaml) mandates
that any port with an 'ethernet' property must also have 'phy-mode'
and one of 'fixed-link', 'phy-handle', or 'managed'.
Add phy-mode = "internal" and a fixed-link subnode to ports 5, 7
and 8, matching the properties already present on their respective
GMAC nodes (gmac0, gmac1, gmac2). This resolves dtbs_check schema
validation warnings for all BCM5301x-based board DTBs.
Assisted-by: Opencode:Big-Pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
arch/arm/boot/dts/broadcom/bcm-ns.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/broadcom/bcm-ns.dtsi b/arch/arm/boot/dts/broadcom/bcm-ns.dtsi
index 27a97c8122de..609f56ab936c 100644
--- a/arch/arm/boot/dts/broadcom/bcm-ns.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm-ns.dtsi
@@ -439,16 +439,29 @@ port@4 {
port@5 {
reg = <5>;
ethernet = <&gmac0>;
+ phy-mode = "internal";
+
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
};
port@7 {
reg = <7>;
ethernet = <&gmac1>;
+ phy-mode = "internal";
+
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
};
port@8 {
reg = <8>;
ethernet = <&gmac2>;
+ phy-mode = "internal";
fixed-link {
speed = <1000>;
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: BCM5301X: Add missing phy-mode and fixed-link to DSA switch ports
2026-07-27 22:17 [PATCH] ARM: dts: BCM5301X: Add missing phy-mode and fixed-link to DSA switch ports Rosen Penev
@ 2026-07-30 23:26 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2026-07-30 23:26 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Rosen Penev, devicetree
Cc: Florian Fainelli, Hauke Mehrtens, Rafał Miłecki,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
moderated list:BROADCOM BCM5301X ARM ARCHITECTURE, open list
From: Florian Fainelli <f.fainelli@gmail.com>
On Mon, 27 Jul 2026 15:17:28 -0700, Rosen Penev <rosenp@gmail.com> wrote:
> Ports 5, 7 and 8 in the BCM5301x SRAB switch node carry an 'ethernet'
> property linking them to GMACs, but lack the required 'phy-mode' and
> 'fixed-link' properties. The DSA port schema (dsa-port.yaml) mandates
> that any port with an 'ethernet' property must also have 'phy-mode'
> and one of 'fixed-link', 'phy-handle', or 'managed'.
>
> Add phy-mode = "internal" and a fixed-link subnode to ports 5, 7
> and 8, matching the properties already present on their respective
> GMAC nodes (gmac0, gmac1, gmac2). This resolves dtbs_check schema
> validation warnings for all BCM5301x-based board DTBs.
>
> Assisted-by: Opencode:Big-Pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-30 23:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-27 22:17 [PATCH] ARM: dts: BCM5301X: Add missing phy-mode and fixed-link to DSA switch ports Rosen Penev
2026-07-30 23:26 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®