mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3] regulator: palmas: Check return value of palmas_smps_write()
@ 2026-07-28 12:30 Aleksandrova Alyona
  0 siblings, 0 replies; only message in thread
From: Aleksandrova Alyona @ 2026-07-28 12:30 UTC (permalink / raw)
  To: Mark Brown
  Cc: Tony Lindgren, Liam Girdwood, Laxman Dewangan, linux-omap,
	linux-kernel, lvc-project

palmas_set_mode_smps() updates the SMPS mode register when the rail is
enabled, but it ignores a possible error from palmas_smps_write().

If the register write fails, the function still reports success to the
caller even though the hardware mode has not been updated.

Return the error if palmas_smps_write() fails. Update current_reg_mode
and enable_val only after a successful register write so that the cached
driver state remains consistent with the hardware state.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 51d3a0c999e1 ("regulator: palmas: preserve modes of rails during enable/disable")
Signed-off-by: Aleksandrova Alyona <aga@itb.spb.ru>
---
v3:
- Remove the unnecessary new_mode variable.

v2:
- Update current_reg_mode and enable_val only after a successful register
  write to keep the cached state consistent with the hardware state.

 drivers/regulator/palmas-regulator.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index 337dd614695e..d0e604780750 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -468,9 +468,14 @@ static int palmas_set_mode_smps(struct regulator_dev *dev, unsigned int mode)
 		return -EINVAL;
 	}
 
-	pmic->current_reg_mode[id] = reg & PALMAS_SMPS12_CTRL_MODE_ACTIVE_MASK;
-	if (rail_enable)
-		palmas_smps_write(pmic->palmas, rinfo->ctrl_addr, reg);
+	if (rail_enable) {
+		ret = palmas_smps_write(pmic->palmas, rinfo->ctrl_addr, reg);
+		if (ret)
+			return ret;
+	}
+
+	pmic->current_reg_mode[id] =
+		reg & PALMAS_SMPS12_CTRL_MODE_ACTIVE_MASK;
 
 	/* Switch the enable value to ensure this is used for enable */
 	pmic->desc[id].enable_val = pmic->current_reg_mode[id];
-- 
2.26.2


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-28 12:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-28 12:30 [PATCH v3] regulator: palmas: Check return value of palmas_smps_write() Aleksandrova Alyona

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®