* [PATCH] perf build: Fix a build error on 32-bit x86
@ 2026-07-30 23:59 Namhyung Kim
2026-08-03 17:33 ` Namhyung Kim
0 siblings, 1 reply; 2+ messages in thread
From: Namhyung Kim @ 2026-07-30 23:59 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Ian Rogers, Jiri Olsa, Adrian Hunter, James Clark,
Peter Zijlstra, Ingo Molnar, LKML, linux-perf-users
The commit d7507a94a072 ("KVM: SVM: Treat exit_code as an unsigned
64-bit value through all of KVM") added "ull" suffix to SVM exit codes
and it makes the 32-bit build fail like below.
In file included from util/kvm-stat-arch/kvm-stat-x86.c:4:
util/kvm-stat-arch/../../../arch/x86/include/uapi/asm/svm.h:137:32:
error: conversion from 'long long unsigned int' to 'long unsigned int' changes
value from '18446744073709551615' to '4294967295' [-Werror=overflow]
137 | #define SVM_EXIT_ERR -1ull
| ^
util/kvm-stat-arch/../kvm-stat.h:131:17: note: in definition of macro 'define_exit_reasons_table'
131 | symbols, { -1, NULL } \
| ^~~~~~~
util/kvm-stat-arch/../../../arch/x86/include/uapi/asm/svm.h:249:11: note: in expansion of macro 'SVM_EXIT_ERR'
249 | { SVM_EXIT_ERR, "invalid_guest_state" }
| ^~~~~~~~~~~~
util/kvm-stat-arch/kvm-stat-x86.c:12:45: note: in expansion of macro 'SVM_EXIT_REASONS'
12 | define_exit_reasons_table(svm_exit_reasons, SVM_EXIT_REASONS);
| ^~~~~~~~~~~~~~~~
As the exit_code was unsigned long, the compiler complained about the
truncation. Let's convert it to u64 to suppress the error.
Fixes: fac520e43a60 ("tools headers: Sync KVM headers with the kernel sources")
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/kvm-stat.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/kvm-stat.h b/tools/perf/util/kvm-stat.h
index 1db31c0751875875..8eee8d073f4147f2 100644
--- a/tools/perf/util/kvm-stat.h
+++ b/tools/perf/util/kvm-stat.h
@@ -69,7 +69,7 @@ struct kvm_events_ops {
};
struct exit_reasons_table {
- unsigned long exit_code;
+ u64 exit_code;
const char *reason;
};
--
2.55.0.571.g244d577d93-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] perf build: Fix a build error on 32-bit x86
2026-07-30 23:59 [PATCH] perf build: Fix a build error on 32-bit x86 Namhyung Kim
@ 2026-08-03 17:33 ` Namhyung Kim
0 siblings, 0 replies; 2+ messages in thread
From: Namhyung Kim @ 2026-08-03 17:33 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Namhyung Kim
Cc: Ian Rogers, Jiri Olsa, Adrian Hunter, James Clark,
Peter Zijlstra, Ingo Molnar, LKML, linux-perf-users
On Thu, 30 Jul 2026 16:59:46 -0700, Namhyung Kim wrote:
> The commit d7507a94a072 ("KVM: SVM: Treat exit_code as an unsigned
> 64-bit value through all of KVM") added "ull" suffix to SVM exit codes
> and it makes the 32-bit build fail like below.
>
> In file included from util/kvm-stat-arch/kvm-stat-x86.c:4:
> util/kvm-stat-arch/../../../arch/x86/include/uapi/asm/svm.h:137:32:
> error: conversion from 'long long unsigned int' to 'long unsigned int' changes
> value from '18446744073709551615' to '4294967295' [-Werror=overflow]
> 137 | #define SVM_EXIT_ERR -1ull
> | ^
> util/kvm-stat-arch/../kvm-stat.h:131:17: note: in definition of macro 'define_exit_reasons_table'
> 131 | symbols, { -1, NULL } \
> | ^~~~~~~
> util/kvm-stat-arch/../../../arch/x86/include/uapi/asm/svm.h:249:11: note: in expansion of macro 'SVM_EXIT_ERR'
> 249 | { SVM_EXIT_ERR, "invalid_guest_state" }
> | ^~~~~~~~~~~~
> util/kvm-stat-arch/kvm-stat-x86.c:12:45: note: in expansion of macro 'SVM_EXIT_REASONS'
> 12 | define_exit_reasons_table(svm_exit_reasons, SVM_EXIT_REASONS);
> | ^~~~~~~~~~~~~~~~
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-03 17:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-30 23:59 [PATCH] perf build: Fix a build error on 32-bit x86 Namhyung Kim
2026-08-03 17:33 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®