From: Ivy Lopez <skunkolee@gmail.com>
To: kees@kernel.org
Cc: linux-kernel@vger.kernel.org, Ivy Lopez <skunkolee@gmail.com>
Subject: [PATCH] bus: arm-cci: fix device_node reference leak in cci_probe_ports()
Date: Fri, 31 Jul 2026 12:02:27 -0600 [thread overview]
Message-ID: <20260731180227.234386-1-skunkolee@gmail.com> (raw)
for_each_available_child_of_node() takes a reference on each child
node in turn. When the number of matching CCI interface nodes in
the DT exceeds nb_cci_ports, the loop exits via break without
dropping the reference held on the current node, leaking it.
Add the missing of_node_put() before the break.
Signed-off-by: Ivy Lopez <skunkolee@gmail.com>
---
drivers/bus/arm-cci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index 7f2baf057128..5ab3d74c9ae2 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np)
i = nb_ace + nb_ace_lite;
- if (i >= nb_cci_ports)
+ if (i >= nb_cci_ports) {
+ of_node_put(cp);
break;
+ }
if (of_property_read_string(cp, "interface-type",
&match_str)) {
--
2.55.0
next reply other threads:[~2026-07-31 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 18:02 Ivy Lopez [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-11-08 6:32 [PATCH] bus: arm-cci: Fix device node " Erick Karanja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260731180227.234386-1-skunkolee@gmail.com \
--to=skunkolee@gmail.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®