mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiaxing Hu <gahing@gahingwoo.com>
To: royalnet026@gmail.com
Cc: tomeu@tomeuvizoso.net, heiko@sntech.de,
	linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Jiaxing Hu <gahing@gahingwoo.com>
Subject: Re: [PATCH v2 2/2] accel/rocket: keep core slots stable across unbind and rebind
Date: Sat,  1 Aug 2026 15:36:14 +1200	[thread overview]
Message-ID: <20260801033614.2008530-1-gahing@gahingwoo.com> (raw)
In-Reply-To: <20260731064933.12548-3-royalnet026@gmail.com>

Hi Igor,

All three are addressed, and in the right places. The .dev = NULL lands
in the rocket_core_init() failure path before num_cores is decremented,
which is what keeps the live slot count and the scheds allocation in
step. The .dev check in sched_to_core() and the note about synchronous
probe are both what I had in mind. Thanks for exercising the forced
init failure path on hardware too.

Reviewed-by: Jiaxing Hu <gahing@gahingwoo.com>

And thanks for the Tested-by on my v3. RK3588 is the part I cannot
check here, so having the soc_data conversion confirmed on all three
cores is worth a lot.

Cheers,
Jiaxing

  reply	other threads:[~2026-08-01  3:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31  6:49 [PATCH v2 0/2] accel/rocket: fix shared-device lifecycle on probe failure and unbind Igor Paunovic
2026-07-31  6:49 ` [PATCH v2 1/2] accel/rocket: release the shared device's devres on teardown Igor Paunovic
2026-07-31  6:49 ` [PATCH v2 2/2] accel/rocket: keep core slots stable across unbind and rebind Igor Paunovic
2026-08-01  3:36   ` Jiaxing Hu [this message]
2026-08-12 13:03 ` [PATCH v2 0/2] accel/rocket: fix shared-device lifecycle on probe failure and unbind Igor Paunovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260801033614.2008530-1-gahing@gahingwoo.com \
    --to=gahing@gahingwoo.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=royalnet026@gmail.com \
    --cc=tomeu@tomeuvizoso.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®