mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam via B4 Relay <devnull+manivannan.sadhasivam.oss.qualcomm.com@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	 linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzk@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	 Manivannan Sadhasivam <mani@kernel.org>,
	 Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Subject: [PATCH 01/28] dt-bindings: phy: qcom: Describe QMP USB and UFS PHY vdda-phy/vdda-pll voltages
Date: Mon, 03 Aug 2026 08:33:59 +0200	[thread overview]
Message-ID: <20260803-phy-supply-fix-v1-1-5880630cde3e@oss.qualcomm.com> (raw)
In-Reply-To: <20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com>

From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

The vdda-phy and vdda-pll supplies of the QMP USB and UFS PHYs are
frequently swapped in devicetrees, as the naming does not make clear
which supply expects which voltage. Document that vdda-phy is around
0.8V and vdda-pll is around 1.2V, with the exact voltage varying per
SoC, so that the correct supplies can be assigned.

Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
 .../devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml   | 10 ++++++++--
 .../devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml  | 10 ++++++++--
 .../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml   | 12 +++++++++---
 .../bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml         | 12 +++++++++---
 .../bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml          | 10 ++++++++--
 5 files changed, 42 insertions(+), 12 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml
index 1636285fbe53..4cbcf54aef2c 100644
--- a/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml
@@ -39,9 +39,15 @@ properties:
       - const: phy
       - const: phy_phy
 
-  vdda-phy-supply: true
+  vdda-phy-supply:
+    description:
+      Supply for the PHY, typically around 0.8V, though the exact voltage
+      varies per SoC.
 
-  vdda-pll-supply: true
+  vdda-pll-supply:
+    description:
+      Supply for the PLL, typically around 1.2V, though the exact voltage
+      varies per SoC.
 
   "#clock-cells":
     const: 0
diff --git a/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml
index efb465c71c1b..9dbe49afaa6c 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml
@@ -40,9 +40,15 @@ properties:
       - const: phy_phy
       - const: dp_phy
 
-  vdda-phy-supply: true
+  vdda-phy-supply:
+    description:
+      Supply for the PHY, typically around 0.8V, though the exact voltage
+      varies per SoC.
 
-  vdda-pll-supply: true
+  vdda-pll-supply:
+    description:
+      Supply for the PLL, typically around 1.2V, though the exact voltage
+      varies per SoC.
 
   "#clock-cells":
     const: 1
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
index b2c5c9a375a3..968a700d2a55 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
@@ -81,9 +81,15 @@ properties:
     items:
       - const: ufsphy
 
-  vdda-phy-supply: true
-
-  vdda-pll-supply: true
+  vdda-phy-supply:
+    description:
+      Supply for the PHY, typically around 0.8V, though the exact voltage
+      varies per SoC.
+
+  vdda-pll-supply:
+    description:
+      Supply for the PLL, typically around 1.2V, though the exact voltage
+      varies per SoC.
 
   "#clock-cells":
     const: 1
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
index 01342823e57f..532afa116ba0 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
@@ -64,9 +64,15 @@ properties:
       - const: phy
       - const: phy_phy
 
-  vdda-phy-supply: true
-
-  vdda-pll-supply: true
+  vdda-phy-supply:
+    description:
+      Supply for the PHY, typically around 0.8V, though the exact voltage
+      varies per SoC.
+
+  vdda-pll-supply:
+    description:
+      Supply for the PLL, typically around 1.2V, though the exact voltage
+      varies per SoC.
 
   refgen-supply: true
 
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
index 4eff92343ce4..865395fe1416 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
@@ -69,9 +69,15 @@ properties:
       - const: phy
       - const: common
 
-  vdda-phy-supply: true
+  vdda-phy-supply:
+    description:
+      Supply for the PHY, typically around 0.8V, though the exact voltage
+      varies per SoC.
 
-  vdda-pll-supply: true
+  vdda-pll-supply:
+    description:
+      Supply for the PLL, typically around 1.2V, though the exact voltage
+      varies per SoC.
 
   refgen-supply: true
 

-- 
2.43.0



  reply	other threads:[~2026-08-03  6:34 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03  6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
2026-08-03  6:33 ` Manivannan Sadhasivam via B4 Relay [this message]
2026-08-04  8:36   ` [PATCH 01/28] dt-bindings: phy: qcom: Describe QMP USB and UFS PHY vdda-phy/vdda-pll voltages Krzysztof Kozlowski
2026-08-03  6:34 ` [PATCH 02/28] arm64: dts: qcom: sc8280xp-blackrock: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 03/28] arm64: dts: qcom: sa8540p: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 04/28] arm64: dts: qcom: sdm845: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 05/28] arm64: dts: qcom: sdm850: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 06/28] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 07/28] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 08/28] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 09/28] arm64: dts: qcom: sm8450: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 10/28] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 11/28] arm64: dts: qcom: qcs8550-aim300: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 12/28] arm64: dts: qcom: qcm6490: " Manivannan Sadhasivam via B4 Relay
2026-08-04 13:24   ` Luca Weiss
2026-08-03  6:34 ` [PATCH 13/28] arm64: dts: qcom: qcs6490: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 14/28] arm64: dts: qcom: sm7225-fairphone-fp4: " Manivannan Sadhasivam via B4 Relay
2026-08-04 13:26   ` Luca Weiss
2026-08-03  6:34 ` [PATCH 15/28] arm64: dts: qcom: sc7180: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 16/28] arm64: dts: qcom: sc7280: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 17/28] arm64: dts: qcom: sc8180x: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 18/28] arm64: dts: qcom: hamoa: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 19/28] arm64: dts: qcom: purwa: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 20/28] arm64: dts: qcom: sm8650: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 21/28] arm64: dts: qcom: sm8750: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 22/28] arm64: dts: qcom: sar2130p: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 23/28] arm64: dts: qcom: kaanapali: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 24/28] arm64: dts: qcom: glymur: " Manivannan Sadhasivam via B4 Relay
2026-08-04 11:51   ` Abel Vesa
2026-08-03  6:34 ` [PATCH 25/28] arm64: dts: qcom: lemans: " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 26/28] arm64: dts: qcom: eliza-mtp: " Manivannan Sadhasivam via B4 Relay
2026-08-04 11:51   ` Abel Vesa
2026-08-03  6:34 ` [PATCH 27/28] arm64: dts: qcom: sa8155p-adp: Fix swapped USB and UFS " Manivannan Sadhasivam via B4 Relay
2026-08-03  6:34 ` [PATCH 28/28] arm64: dts: qcom: talos-evk: Fix swapped USB " Manivannan Sadhasivam via B4 Relay
2026-08-05  3:33 ` [PATCH 00/28] arm64: dts: qcom: Fix swapped " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260803-phy-supply-fix-v1-1-5880630cde3e@oss.qualcomm.com \
    --to=devnull+manivannan.sadhasivam.oss.qualcomm.com@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®