* [PATCH 1/5] spi: dt-bindings: andestech,ae350-spi: Drop redundant num-cs
2026-08-04 7:16 [PATCH 0/5] spi: Few cleanups while looking at num-cs Krzysztof Kozlowski
@ 2026-08-04 7:16 ` Krzysztof Kozlowski
2026-08-04 7:16 ` [PATCH 2/5] spi: dt-bindings: marvell,armada-3700-spi: " Krzysztof Kozlowski
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-04 7:16 UTC (permalink / raw)
To: CL Wang, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Kousik Sanagavarapu, Vladimir Moravcevic,
Tzu-Hao Wei, Swark Yang, Prasad Bolisetty, Karthikeyan Mitran,
Michal Simek
Cc: linux-spi, devicetree, linux-kernel, linux-arm-kernel,
Krzysztof Kozlowski
'num-cs' property is a single integer, thus the binding should not set
maxItems. This could be replaced with proper min/max constraints for
values, except that hardware (as expressed in driver) supports only one
native chipselect, thus constraint of "const:1" would make the property
implied by the compatible. spi-controller.yaml schema already defines
this property, so its presence here is redundant.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Documentation/devicetree/bindings/spi/andestech,ae350-spi.yaml | 4 ----
1 file changed, 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/andestech,ae350-spi.yaml b/Documentation/devicetree/bindings/spi/andestech,ae350-spi.yaml
index 8e441742cee6..381042e07fd0 100644
--- a/Documentation/devicetree/bindings/spi/andestech,ae350-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/andestech,ae350-spi.yaml
@@ -24,10 +24,6 @@ properties:
clocks:
maxItems: 1
- num-cs:
- description: Number of chip selects supported
- maxItems: 1
-
dmas:
items:
- description: Transmit FIFO DMA channel
--
2.53.0
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 2/5] spi: dt-bindings: marvell,armada-3700-spi: Drop redundant num-cs
2026-08-04 7:16 [PATCH 0/5] spi: Few cleanups while looking at num-cs Krzysztof Kozlowski
2026-08-04 7:16 ` [PATCH 1/5] spi: dt-bindings: andestech,ae350-spi: Drop redundant num-cs Krzysztof Kozlowski
@ 2026-08-04 7:16 ` Krzysztof Kozlowski
2026-08-04 7:16 ` [PATCH 3/5] spi: dt-bindings: axiado,ax3000-spi: Drop duplicated type/ref Krzysztof Kozlowski
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-04 7:16 UTC (permalink / raw)
To: CL Wang, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Kousik Sanagavarapu, Vladimir Moravcevic,
Tzu-Hao Wei, Swark Yang, Prasad Bolisetty, Karthikeyan Mitran,
Michal Simek
Cc: linux-spi, devicetree, linux-kernel, linux-arm-kernel,
Krzysztof Kozlowski
'num-cs' property is a single integer, thus the binding should not set
maxItems. This could be replaced with proper min/max constraints for
values, except that such constraints are not known.
spi-controller.yaml schema already defines this property, so its
presence here is redundant.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Documentation/devicetree/bindings/spi/marvell,armada-3700-spi.yaml | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/marvell,armada-3700-spi.yaml b/Documentation/devicetree/bindings/spi/marvell,armada-3700-spi.yaml
index 61caa1d86188..75437c46e65a 100644
--- a/Documentation/devicetree/bindings/spi/marvell,armada-3700-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/marvell,armada-3700-spi.yaml
@@ -28,9 +28,6 @@ properties:
clocks:
maxItems: 1
- num-cs:
- maxItems: 1
-
required:
- compatible
- reg
--
2.53.0
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 3/5] spi: dt-bindings: axiado,ax3000-spi: Drop duplicated type/ref
2026-08-04 7:16 [PATCH 0/5] spi: Few cleanups while looking at num-cs Krzysztof Kozlowski
2026-08-04 7:16 ` [PATCH 1/5] spi: dt-bindings: andestech,ae350-spi: Drop redundant num-cs Krzysztof Kozlowski
2026-08-04 7:16 ` [PATCH 2/5] spi: dt-bindings: marvell,armada-3700-spi: " Krzysztof Kozlowski
@ 2026-08-04 7:16 ` Krzysztof Kozlowski
2026-08-04 7:17 ` [PATCH 4/5] spi: dt-bindings: spi-cadence: " Krzysztof Kozlowski
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-04 7:16 UTC (permalink / raw)
To: CL Wang, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Kousik Sanagavarapu, Vladimir Moravcevic,
Tzu-Hao Wei, Swark Yang, Prasad Bolisetty, Karthikeyan Mitran,
Michal Simek
Cc: linux-spi, devicetree, linux-kernel, linux-arm-kernel,
Krzysztof Kozlowski
spi-controller.yaml schema already defines this $ref for this property,
so binding does not have to.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Documentation/devicetree/bindings/spi/axiado,ax3000-spi.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/spi/axiado,ax3000-spi.yaml b/Documentation/devicetree/bindings/spi/axiado,ax3000-spi.yaml
index cd2aac66fca2..be258c1f36b1 100644
--- a/Documentation/devicetree/bindings/spi/axiado,ax3000-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/axiado,ax3000-spi.yaml
@@ -37,7 +37,6 @@ properties:
num-cs:
description: |
Number of chip selects used.
- $ref: /schemas/types.yaml#/definitions/uint32
minimum: 1
maximum: 4
default: 4
--
2.53.0
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 4/5] spi: dt-bindings: spi-cadence: Drop duplicated type/ref
2026-08-04 7:16 [PATCH 0/5] spi: Few cleanups while looking at num-cs Krzysztof Kozlowski
` (2 preceding siblings ...)
2026-08-04 7:16 ` [PATCH 3/5] spi: dt-bindings: axiado,ax3000-spi: Drop duplicated type/ref Krzysztof Kozlowski
@ 2026-08-04 7:17 ` Krzysztof Kozlowski
2026-08-04 7:17 ` [PATCH 5/5] spi: atcspi200: Drop redundant andestech,qilai-spi compatible Krzysztof Kozlowski
2026-08-04 17:51 ` [PATCH 0/5] spi: Few cleanups while looking at num-cs Mark Brown
5 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-04 7:17 UTC (permalink / raw)
To: CL Wang, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Kousik Sanagavarapu, Vladimir Moravcevic,
Tzu-Hao Wei, Swark Yang, Prasad Bolisetty, Karthikeyan Mitran,
Michal Simek
Cc: linux-spi, devicetree, linux-kernel, linux-arm-kernel,
Krzysztof Kozlowski
spi-controller.yaml schema already defines this $ref for this property,
so binding does not have to.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Documentation/devicetree/bindings/spi/spi-cadence.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
index 347bed0c4956..429cd824156c 100644
--- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
@@ -43,7 +43,6 @@ properties:
Number of chip selects used. If a decoder is used,
this will be the number of chip selects after the
decoder.
- $ref: /schemas/types.yaml#/definitions/uint32
minimum: 1
maximum: 4
default: 4
--
2.53.0
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 5/5] spi: atcspi200: Drop redundant andestech,qilai-spi compatible
2026-08-04 7:16 [PATCH 0/5] spi: Few cleanups while looking at num-cs Krzysztof Kozlowski
` (3 preceding siblings ...)
2026-08-04 7:17 ` [PATCH 4/5] spi: dt-bindings: spi-cadence: " Krzysztof Kozlowski
@ 2026-08-04 7:17 ` Krzysztof Kozlowski
2026-08-04 17:51 ` [PATCH 0/5] spi: Few cleanups while looking at num-cs Mark Brown
5 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-04 7:17 UTC (permalink / raw)
To: CL Wang, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Kousik Sanagavarapu, Vladimir Moravcevic,
Tzu-Hao Wei, Swark Yang, Prasad Bolisetty, Karthikeyan Mitran,
Michal Simek
Cc: linux-spi, devicetree, linux-kernel, linux-arm-kernel,
Krzysztof Kozlowski
"andestech,qilai-spi" compatible can only be used with a fallback, which
is already matched by the driver's OF device ID table, thus it is
redundant in the driver.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
drivers/spi/spi-atcspi200.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-atcspi200.c b/drivers/spi/spi-atcspi200.c
index b6ea8e556335..b532c58c0ab9 100644
--- a/drivers/spi/spi-atcspi200.c
+++ b/drivers/spi/spi-atcspi200.c
@@ -638,7 +638,6 @@ static int atcspi_resume(struct device *dev)
static DEFINE_SIMPLE_DEV_PM_OPS(atcspi_pm_ops, atcspi_suspend, atcspi_resume);
static const struct of_device_id atcspi_of_match[] = {
- { .compatible = "andestech,qilai-spi", },
{ .compatible = "andestech,ae350-spi", },
{ /* sentinel */ }
};
--
2.53.0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 0/5] spi: Few cleanups while looking at num-cs
2026-08-04 7:16 [PATCH 0/5] spi: Few cleanups while looking at num-cs Krzysztof Kozlowski
` (4 preceding siblings ...)
2026-08-04 7:17 ` [PATCH 5/5] spi: atcspi200: Drop redundant andestech,qilai-spi compatible Krzysztof Kozlowski
@ 2026-08-04 17:51 ` Mark Brown
5 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2026-08-04 17:51 UTC (permalink / raw)
To: CL Wang, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Kousik Sanagavarapu, Vladimir Moravcevic, Tzu-Hao Wei,
Swark Yang, Prasad Bolisetty, Karthikeyan Mitran, Michal Simek,
Krzysztof Kozlowski
Cc: linux-spi, devicetree, linux-kernel, linux-arm-kernel
On Tue, 04 Aug 2026 09:16:56 +0200, Krzysztof Kozlowski wrote:
> spi: Few cleanups while looking at num-cs
>
> Few minor cleanups for DT bindings and Andes driver.
>
> Patches do not have inter-dependencies.
>
> Best regards,
> Krzysztof
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.3
Thanks!
[1/5] spi: dt-bindings: andestech,ae350-spi: Drop redundant num-cs
https://git.kernel.org/broonie/spi/c/82024a7ae057
[2/5] spi: dt-bindings: marvell,armada-3700-spi: Drop redundant num-cs
https://git.kernel.org/broonie/spi/c/9ec27e118da7
[3/5] spi: dt-bindings: axiado,ax3000-spi: Drop duplicated type/ref
https://git.kernel.org/broonie/spi/c/577ada5875dc
[4/5] spi: dt-bindings: spi-cadence: Drop duplicated type/ref
https://git.kernel.org/broonie/spi/c/ad0dcba3ab9c
[5/5] spi: atcspi200: Drop redundant andestech,qilai-spi compatible
https://git.kernel.org/broonie/spi/c/463c840f54f8
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 7+ messages in thread