From: Sanghyun Park <sanghyun.park.cnu@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Sanghyun Park <sanghyun.park.cnu@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Sun Jian <sun.jian.kdev@gmail.com>,
Puranjay Mohan <puranjay@kernel.org>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+cdd6c0925e12b0af60cc@syzkaller.appspotmail.com,
sashiko-bot@kernel.org
Subject: Re: [PATCH bpf-next v2] bpf: Fix mmap_lock leak in irq_work path
Date: Tue, 4 Aug 2026 10:08:21 +0900 [thread overview]
Message-ID: <20260804010821.3756062-2-sanghyun.park.cnu@gmail.com> (raw)
In-Reply-To: <CAEf4BzZ703vZPOFobvSLskKA2DzQXpMcDd1jEaydGEwjx6O+sQ@mail.gmail.com>
On Mon, Aug 3, 2026 at 5:44 PM UTC, Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> I'm just not sure that re-queueing works if irq_work_is_busy() returns
> true, please double check. If that doesn't work, then we can miss the
> irq_work callback, which would be bad.
I see your point. I double-checked this, and re-queueing seems to work.
However, keeping the irq_work_is_busy() check only adds one flag read, so the
performance impact is quite negligible. I'll keep both checks in a conservative
manner.
prev parent reply other threads:[~2026-08-04 1:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 5:48 Sanghyun Park
2026-07-30 7:19 ` bot+bpf-ci
2026-07-30 23:50 ` Andrii Nakryiko
2026-08-03 9:44 ` Sanghyun Park
2026-08-03 17:44 ` Andrii Nakryiko
2026-08-04 1:08 ` Sanghyun Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804010821.3756062-2-sanghyun.park.cnu@gmail.com \
--to=sanghyun.park.cnu@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=puranjay@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=song@kernel.org \
--cc=sun.jian.kdev@gmail.com \
--cc=syzbot+cdd6c0925e12b0af60cc@syzkaller.appspotmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®