* [PATCH v2] staging: rtl8723bs: convert swing index variables from u8 to int
[not found] <YOUR-ORIGINAL-MESSAGE-ID>
@ 2026-08-04 17:01 ` Mohit Mishra
0 siblings, 0 replies; only message in thread
From: Mohit Mishra @ 2026-08-04 17:01 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Dan Carpenter, Nikolay Kulikov, linux-staging, linux-kernel,
Mohit Mishra
In ODM_TxPwrTrackSetPwr_8723B(), Final_OFDM_Swing_Index and
Final_CCK_Swing_Index are declared as u8. Using u8 for variables involved
in arithmetic calculations and lower-bound comparisons (<= 0) is unusual
and triggers static analysis warnings.
Convert both variables from u8 to int to clean up the variable types,
aligning with the TODO item to "convert any remaining unusual variable
types".
Signed-off-by: Mohit Mishra <mishraloopmohit@gmail.com>
---
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
index 6c5f56d5a1f4..2ec2d4aada56 100644
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
@@ -160,8 +160,8 @@ void ODM_TxPwrTrackSetPwr_8723B(
u8 PwrTrackingLimit_OFDM = 34; /* 0dB */
u8 PwrTrackingLimit_CCK = 28; /* 2dB */
u8 TxRate = 0xFF;
- u8 Final_OFDM_Swing_Index = 0;
- u8 Final_CCK_Swing_Index = 0;
+ int Final_OFDM_Swing_Index = 0;
+ int Final_CCK_Swing_Index = 0;
{
u16 rate = *(pDM_Odm->pForcedDataRate);
--
2.43.0
^ permalink raw reply [flat|nested] only message in thread