[PATCH] fs: remove stale inode_insert5() kernel-doc parameter

[PATCH] fs: remove stale inode_insert5() kernel-doc parameter

[Yichong Chen]

inode_insert5() no longer has an isnew argument, but its
kernel-doc still documents one. This triggers a W=1 kernel-doc
warning.

Remove the stale parameter description.

Signed-off-by: Yichong Chen <chenyichong@uniontech.com>
---
 fs/inode.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/inode.c b/fs/inode.c
index a31aa7cb47f6..ed7c8df1bfca 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -1282,7 +1282,6 @@ EXPORT_SYMBOL(unlock_two_nondirectories);
  * @test:	callback used for comparisons between inodes
  * @set:	callback used to initialize a new struct inode
  * @data:	opaque data pointer to pass to @test and @set
- * @isnew:	pointer to a bool which will indicate whether I_NEW is set
  *
  * Search for the inode specified by @hashval and @data in the inode cache,
  * and if present return it with an increased reference count. This is a
-- 
2.51.0

Re: [PATCH] fs: remove stale inode_insert5() kernel-doc parameter

[Jan Kara]

On Wed 05-08-26 10:41:49, Yichong Chen wrote:
> inode_insert5() no longer has an isnew argument, but its
> kernel-doc still documents one. This triggers a W=1 kernel-doc
> warning.
> 
> Remove the stale parameter description.
> 
> Signed-off-by: Yichong Chen <chenyichong@uniontech.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/inode.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/inode.c b/fs/inode.c
> index a31aa7cb47f6..ed7c8df1bfca 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -1282,7 +1282,6 @@ EXPORT_SYMBOL(unlock_two_nondirectories);
>   * @test:	callback used for comparisons between inodes
>   * @set:	callback used to initialize a new struct inode
>   * @data:	opaque data pointer to pass to @test and @set
> - * @isnew:	pointer to a bool which will indicate whether I_NEW is set
>   *
>   * Search for the inode specified by @hashval and @data in the inode cache,
>   * and if present return it with an increased reference count. This is a
> -- 
> 2.51.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: [PATCH] fs: remove stale inode_insert5() kernel-doc parameter

[Christian Brauner]

On Wed, 05 Aug 2026 10:41:49 +0800, Yichong Chen wrote:
> fs: remove stale inode_insert5() kernel-doc parameter

Applied to the vfs-7.3.misc branch of the vfs/vfs.git tree.
Patches in the vfs-7.3.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-7.3.misc

[1/1] fs: remove stale inode_insert5() kernel-doc parameter
      https://git.kernel.org/vfs/vfs/c/28c7347ac297