From: "Diogo Ivo (Schneider Electric)" <diogo.ivo@bootlin.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulfh@kernel.org>, Faiz Abbas <faiz_abbas@ti.com>,
Judith Mendez <jm@ti.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Pascal EBERHARD <pascal.eberhard@se.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
"Diogo Ivo (Schneider Electric)" <diogo.ivo@bootlin.com>,
stable@vger.kernel.org
Subject: [PATCH v3 0/4] mmc: sdhci_am654: Fix DDR50 mode for cards without tuning support
Date: Fri, 07 Aug 2026 13:06:56 +0200 [thread overview]
Message-ID: <20260807-am654-sdhci-v3-0-acc91d7d7e50@bootlin.com> (raw)
DDR50 mode is not required to support the tuning command CMD19 by the
eMMC/SD specification, meaning that calibration may fail on cards that
do not implement it. This series fixes four issues discovered when
using such cards:
- Patch 1 moves the tuning_loop counter from a persistent struct field
to a local variable, preventing failed tuning attempts from depleting
the retry budget across calls.
- Patch 2 ensures the command/data line reset is always performed
after tuning, even on failure, preventing stale data in the
controller buffer.
- Patch 3 clears the ITAPDLY enable and delay values on tuning
failure so that leftover calibration values do not interfere with
subsequent I/O.
- Patch 4 falls back to the DT-provided itap delay value for DDR50
when tuning fails in this mode, making a best-effort attempt at a
known-good delay being programmed.
Together these changes make DDR50 functional on TI J721E SoCs with
cards that lack CMD19 tuning support. This second version addresses
all comments from Sashiko, which I found to be correct.
Signed-off-by: Diogo Ivo (Schneider Electric) <diogo.ivo@bootlin.com>
---
Changes in v3:
- Collect R-b from Judith and A-b from Adrian
- Add debug print when applying DT fallback values (Patch 4)
- Link to v2: https://patch.msgid.link/20260803-am654-sdhci-v2-0-a5ee5be86133@bootlin.com
Changes in v2:
- Add new patch moving tuning_loop to a local variable (Patch 1)
- Clear ITAPDLY array values alongside HW registers on tuning failure (Patch 3)
- Save DT-provided itap delay values for DDR50 in dedicated variables
to preserve them across tuning cycles (Patch 4)
- Link to v1: https://patch.msgid.link/20260729-am654-sdhci-v1-0-7568108e4b9a@bootlin.com
---
Diogo Ivo (Schneider Electric) (4):
mmc: sdhci_am654: Move tuning_loop to local variable
mmc: sdhci_am654: Reset command and data lines on failed tuning
mmc: sdhci_am654: Clear ITAPDLY on tuning failure
mmc: sdhci_am654: Fallback to DT-provided itap delay on DDR50 tuning failure
drivers/mmc/host/sdhci_am654.c | 43 +++++++++++++++++++++++++++---------------
1 file changed, 28 insertions(+), 15 deletions(-)
---
base-commit: f9a2394a23482bfd330911e9c8295b71724feacd
change-id: 20260728-am654-sdhci-85094d458bae
Best regards,
--
Diogo Ivo <diogo.ivo@bootlin.com>
next reply other threads:[~2026-08-07 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 11:06 Diogo Ivo (Schneider Electric) [this message]
2026-08-07 11:06 ` [PATCH v3 1/4] mmc: sdhci_am654: Move tuning_loop to local variable Diogo Ivo (Schneider Electric)
2026-08-07 11:06 ` [PATCH v3 2/4] mmc: sdhci_am654: Reset command and data lines on failed tuning Diogo Ivo (Schneider Electric)
2026-08-07 11:06 ` [PATCH v3 3/4] mmc: sdhci_am654: Clear ITAPDLY on tuning failure Diogo Ivo (Schneider Electric)
2026-08-07 11:07 ` [PATCH v3 4/4] mmc: sdhci_am654: Fallback to DT-provided itap delay on DDR50 " Diogo Ivo (Schneider Electric)
2026-08-11 14:41 ` Mendez, Judith
2026-09-04 9:41 ` [PATCH v3 0/4] mmc: sdhci_am654: Fix DDR50 mode for cards without tuning support Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807-am654-sdhci-v3-0-acc91d7d7e50@bootlin.com \
--to=diogo.ivo@bootlin.com \
--cc=adrian.hunter@intel.com \
--cc=faiz_abbas@ti.com \
--cc=jm@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=pascal.eberhard@se.com \
--cc=stable@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®