* [PATCH] spi: hisi-sfc-v3xx: Propagate errors from optional IRQ lookup
@ 2026-08-07 10:38 phucduc.bui
2026-08-11 15:42 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: phucduc.bui @ 2026-08-07 10:38 UTC (permalink / raw)
To: Mark Brown, Yang Shen; +Cc: linux-spi, linux-kernel, bui duc phuc
From: bui duc phuc <phucduc.bui@gmail.com>
platform_get_irq_optional() returns a positive IRQ number on success or
a negative error code on failure. For an optional IRQ, -ENXIO indicates
that no IRQ is available, while other errors should be propagated.
Instead of only checking for -EPROBE_DEFER, propagate all error codes
returned by platform_get_irq_optional() other than -ENXIO, so that
failures are properly reported to the caller.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
drivers/spi/spi-hisi-sfc-v3xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-hisi-sfc-v3xx.c b/drivers/spi/spi-hisi-sfc-v3xx.c
index d60db579b0fb..0790c7179868 100644
--- a/drivers/spi/spi-hisi-sfc-v3xx.c
+++ b/drivers/spi/spi-hisi-sfc-v3xx.c
@@ -454,8 +454,8 @@ static int hisi_sfc_v3xx_probe(struct platform_device *pdev)
return PTR_ERR(host->regbase);
host->irq = platform_get_irq_optional(pdev, 0);
- if (host->irq == -EPROBE_DEFER)
- return -EPROBE_DEFER;
+ if (host->irq < 0 && host->irq != -ENXIO)
+ return host->irq;
hisi_sfc_v3xx_disable_int(host);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] spi: hisi-sfc-v3xx: Propagate errors from optional IRQ lookup
2026-08-07 10:38 [PATCH] spi: hisi-sfc-v3xx: Propagate errors from optional IRQ lookup phucduc.bui
@ 2026-08-11 15:42 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2026-08-11 15:42 UTC (permalink / raw)
To: Yang Shen, phucduc.bui; +Cc: linux-spi, linux-kernel
On Fri, 07 Aug 2026 17:38:47 +0700, phucduc.bui@gmail.com wrote:
> spi: hisi-sfc-v3xx: Propagate errors from optional IRQ lookup
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.3
Thanks!
[1/1] spi: hisi-sfc-v3xx: Propagate errors from optional IRQ lookup
https://git.kernel.org/broonie/spi/c/e4702b6ff30e
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-11 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-07 10:38 [PATCH] spi: hisi-sfc-v3xx: Propagate errors from optional IRQ lookup phucduc.bui
2026-08-11 15:42 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®