From: Jason Gunthorpe <jgg@ziepe.ca>
To: Pavan Chebbi <pavan.chebbi@broadcom.com>
Cc: michael.chan@broadcom.com, linux-kernel@vger.kernel.org,
dave.jiang@intel.com, saeedm@nvidia.com, jic23@kernel.org,
gospo@broadcom.com, selvin.xavier@broadcom.com, leon@kernel.org,
kalesh-anakkur.purayil@broadcom.com
Subject: Re: [PATCH v5 fwctl 3/3] fwctl/bnxt: add DMA buffer support for HWRM commands
Date: Fri, 7 Aug 2026 11:01:45 -0300 [thread overview]
Message-ID: <20260807140145.GB200537@ziepe.ca> (raw)
In-Reply-To: <CALs4sv3MshxHdQKR33NZvBUQGyfU+AsMJ5tP4KkfTtt-YmY6jg@mail.gmail.com>
On Fri, Aug 07, 2026 at 09:32:34AM +0530, Pavan Chebbi wrote:
> > struct hwrm_dbg_ptrace_input {
> > __le16 req_type;
> > __le16 cmpl_ring;
> > __le16 seq_id;
> > __le16 target_id;
> > __le64 resp_addr;
> > __le32 pdi_cmd_buf_addr[2];
> > __le32 pdi_resp_buf_addr[2];
> > ^^^
> >
> > This is really sketchy to cast an array to a __le64. If it really
> > means a __le64 then the struct should say that, if it doesn't mean a
> > __le64 then this is broken right?
> >
>
> Since hsi.h is generated from the HWRM spec rather than hand authored,
> it'd need to be fixed at that source.
> I will take this as a follow up change that we need to do internally..
But it is correct to be a le64 and the sketchy cast is Ok?
Jason
next prev parent reply other threads:[~2026-08-07 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 10:00 [PATCH v5 fwctl 0/3] fwctl/bnxt: " Pavan Chebbi
2026-07-07 10:00 ` [PATCH v5 fwctl 1/3] fwctl: Add driver_data field to fwctl_rpc Pavan Chebbi
2026-07-07 10:00 ` [PATCH v5 fwctl 2/3] bnxt_en: Update bnxt firmware spec Pavan Chebbi
2026-07-07 10:00 ` [PATCH v5 fwctl 3/3] fwctl/bnxt: add DMA buffer support for HWRM commands Pavan Chebbi
2026-08-06 17:57 ` Jason Gunthorpe
2026-08-07 4:02 ` Pavan Chebbi
2026-08-07 14:01 ` Jason Gunthorpe [this message]
2026-08-07 15:36 ` Pavan Chebbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807140145.GB200537@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dave.jiang@intel.com \
--cc=gospo@broadcom.com \
--cc=jic23@kernel.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=pavan.chebbi@broadcom.com \
--cc=saeedm@nvidia.com \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®