mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mlxbf-bootctl: fix the build error with FIELD_PREP()
@ 2026-08-10 19:10 Nikolay Kulikov
  0 siblings, 0 replies; only message in thread
From: Nikolay Kulikov @ 2026-08-10 19:10 UTC (permalink / raw)
  To: Hans de Goede, Ilpo Järvinen, Vadim Pasternak, Liming Sun
  Cc: platform-driver-x86, linux-kernel, Nikolay Kulikov

rsh_log_store() calls the FIELD_PREP() macro without including the
required header file, resulting a build error:

  CC      drivers/platform/mellanox/mlxbf-bootctl.o
drivers/platform/mellanox/mlxbf-bootctl.c: In function ‘rsh_log_store’:
drivers/platform/mellanox/mlxbf-bootctl.c:429:16: error: implicit declaration of function ‘FIELD_PREP’ [-Wimplicit-function-declaration]
  429 |         data = FIELD_PREP(MLXBF_RSH_LOG_TYPE_MASK, MLXBF_RSH_LOG_TYPE_MSG);
      |                ^~~~~~~~~~

Fix this by including the <linux/bitfield.h> file.

Fixes: e9d1b2d0f7d0 ("mlxbf-bootctl: Add sysfs file for BlueField boot log")
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
 drivers/platform/mellanox/mlxbf-bootctl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/mellanox/mlxbf-bootctl.c b/drivers/platform/mellanox/mlxbf-bootctl.c
index f67c7f56ab2b..9ddc7fa1a973 100644
--- a/drivers/platform/mellanox/mlxbf-bootctl.c
+++ b/drivers/platform/mellanox/mlxbf-bootctl.c
@@ -10,6 +10,7 @@
 
 #include <linux/acpi.h>
 #include <linux/arm-smccc.h>
+#include <linux/bitfield.h>
 #include <linux/delay.h>
 #include <linux/if_ether.h>
 #include <linux/iopoll.h>

---
base-commit: 36b1d3299d0b6aa51485cc9a79b8d94948d5f3d4
change-id: 20260810-mellanox_fix_implicit_declaration-b3be803cbe94

Best regards,
--  
Nikolay Kulikov <nikolayof23@gmail.com>


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-08-10 19:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-10 19:10 [PATCH] mlxbf-bootctl: fix the build error with FIELD_PREP() Nikolay Kulikov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®